-
Notifications
You must be signed in to change notification settings - Fork 798
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Minor: Allow extra argument to '/sites/%s/themes/mine' endpoint #25070
Conversation
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available. Once your PR is ready for review, check one last time that all required checks (other than "Required review") appearing at the bottom of this PR are passing or skipped. Jetpack plugin:
|
a3190b6
to
490e5cc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
ac98468
to
344153c
Compare
projects/plugins/jetpack/json-endpoints/jetpack/json-api-jetpack-endpoints.php
Outdated
Show resolved
Hide resolved
…ck-endpoints.php Co-authored-by: Mark Biek <mark.biek@automattic.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
This PR is a follow up to this other one. The idea is to allow the argument
dont_change_homepage
when POSTing to/sites/%s/themes/mine
.While the name might seem strange is the one actually being sent by Calypso for Simple sites.
For more context see: paYKcK-1Mb-p2#comment-1395
Testing instructions:
/srv/users/[USER]/apps/[USER]/public/wp-load.php
.tail -F /srv/users/[USER]/apps/[USER]/public/wp-content/debug.log
.twenty twenty
theme and pressActivate
Does this pull request change what data or activity we track or use?
No.
Related to Automattic/wp-calypso#56869