removes default value from dont_change_homepage argument #25141
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a follow up to this other one. We need to remove the default value for the
dont_change_homepage
argument since the checks that are already in place check for the existence of this argument not the value. Changing this logic would end up being more complex down the road.For more context see: paYKcK-1Mb-p2#comment-1395
Testing instructions:
/srv/users/[USER]/apps/[USER]/public/wp-load.php
.tail -F /srv/users/[USER]/apps/[USER]/public/wp-content/debug.log
.twenty twenty
theme and pressActivate
Does this pull request change what data or activity we track or use?
No.
Related to Automattic/wp-calypso#56869