Sensei Tailored Flow

[dadish]

Proposed Changes

• Adds a Sensei Tailored flow.

p6rkRX-4VM-p2

Testing Instructions

• Go to calypso.localhost:3000/setup/sensei to kickoff the Sensei Tailored flow.
• Confirm everything works as expected.

You can also test this out with the calypso live link here: https://container-ecstatic-khayyam.calypso.live/setup/sensei

Pre-merge Checklist

• Has the general commit checklist been followed? (PCYsg-hS-p2)
• Have you written new tests for your changes?
• Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
• Have you checked for TypeScript, React or other console errors?
• Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
• Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
• For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-ajp-p2)?

[edanzer]

I just ran through an extra test of this. For the most part, fluid and nice flow. I did notice a few things on the Launchpad screen. Sounds like you may be skipping this screen in the future, so you may or may not fix these. They could also easily be resolved in follow up PRs.

• The Go to Admin link (bottom of sidebar) does not work. We actually recently ran into this when introducing some other flows. I had it myself. The fix (for now) is to reintroduce the deprecated goNext method you were asked above to remove. You can see my exact commit fixing it for another flow here: 9b0278e We need to update launchpad to not rely on that, be we can handle that in a separate PR, and will circular around to remove goNext in the sensei flow when done.
• There are some small styling issues you would never notice if you weren't working on Launchpad. You need to add an extra class (your .sensei class) to ensure all styles apply. Again, you can see a commit to fix the same thing here: 0afac59
• Clicking the Publish first course button should turn off the launchpad screen off, which should mean a) My Home doesn't not redirect to launchpad and b) if you try to load launchpad, it redirects back to My Home. For some reason (b) is not applying. Small issue because users could only get back to that screen by entering the url manually or via the back button. This is something we can also troubleshoot and resolve may be something with launchpad itself.

[gikaragia]

Sounds like you may be skipping this screen in the future, so you may or may not fix these. They could also easily be resolved in follow up PRs.

Indeed for now we will not fix this screen as we intend to remove it in the future. As discussed I also moved SenseiStepContainer outside of packages in 25f5d95. I guess that the reasoning that we placed it there is that it closely relates to StepContainer however putting it inside components is fine too.

[agrullon95]

The styling looks great !
I went through the flow and successfully landed on the launchpad. The launchpad still has some issues like the Go to admin link missing on mobile view port, not working on desktop view, and the site not launching after publishing my first course. Since the flow is behind a feature flag and the launchpad screen is going to be removed in a follow up PR, I dont think its a big deal.

Indeed for now we will not fix this screen as we intend to remove it in the future. As discussed I also moved SenseiStepContainer outside of packages in 25f5d95. I guess that the reasoning that we placed it there is that it closely relates to StepContainer however putting it inside components is fine too.

Moving the SenseiStepContainer to this location makes sense to me. Lets double check with @alshakero to make sure its makes sense to move it into the stepper directory.

[edanzer]

Approving this! This is a BIG PR. I have focused on:

• Confirming that testing works - I can go through the flow without issues as a user.
• Confirming that no harm is done - ie, no unanticipated (negative) effects or regressions outside of the feature flag. The feature flag provides a measure of safety for this PR.
• Confirm the areas of code I know well look good.

I'm comfortable with all that. There are couple caveats:

• I didn't dive too deeply into the logic on specific new Sensei screens. Some have a lot of complex logic. I haven't gone through the logic on those screens in detail. There is confirmation others have.
• There are few issues with the Launchpad screen, but that screen will be removed in a subsequent PR.
• There are some failing tests. Authors checked with Calypso team and it sounds like those can be ignored in this case.