Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stepper: Fix improper import in stepper for Sensei ErrorIcon #81303

Merged
merged 1 commit into from
Aug 31, 2023

Conversation

sirbrillig
Copy link
Member

Proposed Changes

The sensei-step-error components in the stepper reach into the private implementation details of the @automattic/composite-checkout package to use a component that's not part of the package API. That is fragile and will probably break in the future. This bug was added in #71406

In this PR we refactor that component to duplicate the component that was imported instead.

Testing Instructions

None should be needed.

@github-actions
Copy link

github-actions bot commented Aug 31, 2023

@sirbrillig sirbrillig self-assigned this Aug 31, 2023
@sirbrillig sirbrillig requested a review from dadish August 31, 2023 22:58
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Aug 31, 2023
@sirbrillig sirbrillig changed the title Stepper: Fix improper import in stepper for ErrorIcon Stepper: Fix improper import in stepper for Sensei ErrorIcon Aug 31, 2023
@sirbrillig sirbrillig merged commit 7eab746 into trunk Aug 31, 2023
@sirbrillig sirbrillig deleted the fix/improper-sensei-step-import branch August 31, 2023 23:07
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Aug 31, 2023
@matticbot
Copy link
Contributor

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~697 bytes removed 📉 [gzipped])

name            parsed_size           gzip_size
sensei-flow          -987 B  (-0.2%)     -376 B  (-0.3%)
site-purchases       -390 B  (-0.0%)     -161 B  (-0.0%)
purchases            -390 B  (-0.0%)     -161 B  (-0.0%)
checkout             -390 B  (-0.0%)     -160 B  (-0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Async-loaded Components (~160 bytes removed 📉 [gzipped])

name                                             parsed_size           gzip_size
async-load-calypso-my-sites-checkout-modal            -390 B  (-0.0%)     -160 B  (-0.0%)
async-load-calypso-blocks-editor-checkout-modal       -390 B  (-0.0%)     -160 B  (-0.1%)

React components that are loaded lazily, when a certain part of UI is displayed for the first time.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants