Site Management Panel: Update primary styling on buttons

[DustyReagan]

Related to https://github.com/Automattic/dotcom-forge/issues/8783

Proposed Changes

• This PR removes the "primary" button styling from the buttons in the Site Management flyout panels.

Before	After

Before	After

Before	After

Before	After

Before	After

Before	After

Why are these changes being made?

• Decrease competition for the user's attention with too many call-to-action styled buttons.

Testing Instructions

• Use Calypso Live
• Go to /sites and check all of Site Management tabs for "primary" buttons. They should be "regular" buttons, like in the screenshots above.

Pre-merge Checklist

• Has the general commit checklist been followed? (PCYsg-hS-p2)
• Have you written new tests for your changes?
• Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
• Have you checked for TypeScript, React or other console errors?
• Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
• Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
• For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

[github-actions]

Calypso Live (direct link)

https://calypso.live?image=registry.a8c.com/calypso/app:build-118482

Jetpack Cloud live (direct link)

https://calypso.live?image=registry.a8c.com/calypso/app:build-118482&env=jetpack

Automattic for Agencies live (direct link)

https://calypso.live?image=registry.a8c.com/calypso/app:build-118482&env=a8c-for-agencies

[matticbot]

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~18 bytes added 📈 [gzipped])

name                parsed_size           gzip_size
sites-dashboard          +152 B  (+0.0%)      +52 B  (+0.0%)
hosting-features         +152 B  (+0.0%)      +52 B  (+0.0%)
github-deployments       +152 B  (+0.0%)      +52 B  (+0.0%)
site-monitoring          +141 B  (+0.0%)      +46 B  (+0.0%)
site-logs                +130 B  (+0.0%)      +40 B  (+0.0%)
hosting                   +93 B  (+0.0%)      +37 B  (+0.0%)
staging-site              +67 B  (+0.0%)      +30 B  (+0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Async-loaded Components (~10 bytes added 📈 [gzipped])

name                                       parsed_size           gzip_size
async-load-calypso-layout-command-palette        +15 B  (+0.0%)      +10 B  (+0.0%)

React components that are loaded lazily, when a certain part of UI is displayed for the first time.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

[allilevine]

This could be a personal preference, but I think the toggles or "segmented controls" look better with a background. It's hard to tell what's selected at a glance.

The pagination is highlighted with a background:

I found another primary button on a staging site > Staging site tab, should that be a non-primary button too?

[DustyReagan]

Thanks, @allilevine! From this conversation p1725482783281379-slack-C03NLNTPZ2T I've updated the background color of the page numbers and the toggles and updated the "Switch to production site" button.

[davemart-in]

Some feedback:

The add site button should probably have a secondary button style:

I think it's right to have the WP Admin button the primary button on the Overview page:

But in subsequent tabs, I could see us making it the secondary button and allowing the primary button to be used elsewhere. Here are a few examples:

1)Hosting features tab for simple sites:

2. Deployments:

3. Logs:

4. Staging site:

5. The server settings tab is a tough one. Realistically, these should all be on their own separate page, but I think we explored that option and decided not to go that route.

This almost looks like a text field instead of a button:

Can we change the button copy on this to be just "Restore". That should make this feel more like a button.

Then I might just make the Open PHPMyAdmin button the primary button.

[DustyReagan]

Thanks, @davemart-in! I've updated the PR with your feedback. It's ready for another look.

[davemart-in]

Thanks for working through all of this! These changes are a good more in the right direction.