Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SIte management panel - Keep "WP Admin" and "Home" button primary across all tabs #94774

Merged
merged 3 commits into from
Sep 20, 2024

Conversation

DustyReagan
Copy link
Member

@DustyReagan DustyReagan commented Sep 20, 2024

Related to #94770

Proposed Changes

  • This PR makes the "Home" and "WP Admin" buttons in the upper right on the /sites screens always a primary CTA button.
  • To do this, we revert some of the changes made in Site Management Panel: Update primary styling on buttons #94192 that allowed the button to be primary only on specific tabs.
  • This PR doesn't change any other button colors.

Why are these changes being made?

  • Design and user experience.

Testing Instructions

  • Use Calypso Live
  • Go to /sites and open all the Hosting tabs for a simple and Atomic site and confirm the Home and WP Admin buttons are blue.

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?


return (
<>
<Button onClick={ closeSitePreviewPane } className="item-preview__close-preview-button">
{ __( 'Close' ) }
</Button>
<Button
primary={ isHostingOverview }
primary
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is what makes the button blue (the CTA). Everything else in this PR is reverting the supporting code added in #94192

@matticbot
Copy link
Contributor

matticbot commented Sep 20, 2024

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~41 bytes removed 📉 [gzipped])

name                parsed_size           gzip_size
staging-site              -96 B  (-0.0%)      -41 B  (-0.0%)
sites-dashboard           -96 B  (-0.0%)      -41 B  (-0.0%)
site-performance          -96 B  (-0.0%)      -41 B  (-0.0%)
site-monitoring           -96 B  (-0.0%)      -41 B  (-0.0%)
site-logs                 -96 B  (-0.0%)      -41 B  (-0.0%)
hosting-features          -96 B  (-0.0%)      -41 B  (-0.0%)
hosting                   -96 B  (-0.0%)      -41 B  (-0.0%)
github-deployments        -96 B  (-0.0%)      -41 B  (-0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@DustyReagan DustyReagan marked this pull request as ready for review September 20, 2024 14:55
@matticbot
Copy link
Contributor

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • blaze-dashboard
  • command-palette-wp-admin
  • help-center
  • notifications
  • odyssey-stats
  • whats-new
  • wpcom-block-editor

To test WordPress.com changes, run install-plugin.sh $pluginSlug update/sites-home-cta on your sandbox.

@DustyReagan DustyReagan self-assigned this Sep 20, 2024
@DustyReagan DustyReagan requested a review from a team September 20, 2024 15:02
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Sep 20, 2024
@DustyReagan DustyReagan changed the title Make Home and WP Admin buttons always CTA SIte management panel - Keep "WP Admin" and "Home" button primary across all tabs Sep 20, 2024
Copy link
Member

@allilevine allilevine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I clicked through the Hosting tabs for both Simple and Atomic and confirmed that the button stays blue / primary. ✅

@DustyReagan DustyReagan merged commit 965d3a5 into trunk Sep 20, 2024
11 checks passed
@DustyReagan DustyReagan deleted the update/sites-home-cta branch September 20, 2024 17:50
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Sep 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SIte management panel - Keep "WP Admin" button primary across all tabs
3 participants