Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix email upsell page styles in site context #98152

Merged

Conversation

Imran92
Copy link
Contributor

@Imran92 Imran92 commented Jan 9, 2025

Related to #97961
and #97962

Proposed Changes

  • Fix the contents getting too wide in site-context
  • Fix the revamp classes not getting assigned in site-context
  • FIx the back button being visible
  • Fix context menu not appearing in site-context on Email inbox list

Why are these changes being made?

  • Domain management revamp - site context

Testing Instructions

  • Enable the feature flag by window.sessionStorage.setItem('flags', 'calypso/all-domain-management')
  • Purchase a blog domain and attach a site with it. Don't purchase any mailbox and don't any email forward either
  • Now go to calypso.localhost:3000/sites and open this site in flyout
  • Scroll to bottom and click on the row to open the domain in site context
  • Ensure that the site overview page looks the same as when it's not in site-context
  • Now switch to the Emails tab and make sure everything looks the same as in domain-context
  • Make sure no design in breaking in domain-context
  • Now purchase one or more professional emails for this domain or another domain
  • Open that domain in site context and switch to the Emails tab
  • Make sure the emails list look and work the same as domain-context email list page
Screen.Recording.2025-01-09.at.8.38.48.PM.mov

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
    • For UI changes, have we tested the change in various languages (for example, ES, PT, FR, or DE)? The length of text and words vary significantly between languages.
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@Imran92 Imran92 requested a review from a team January 9, 2025 14:42
@Imran92 Imran92 self-assigned this Jan 9, 2025
@Imran92 Imran92 requested a review from a team as a code owner January 9, 2025 14:42
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Jan 9, 2025
@matticbot
Copy link
Contributor

matticbot commented Jan 9, 2025

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~123 bytes added 📈 [gzipped])

name                        parsed_size           gzip_size
hosting                          +235 B  (+0.0%)      +85 B  (+0.0%)
domains                          +214 B  (+0.0%)      +74 B  (+0.0%)
site-overview                    +124 B  (+0.0%)      +54 B  (+0.0%)
email                             +98 B  (+0.0%)      +28 B  (+0.0%)
staging-site                      +17 B  (+0.0%)      +13 B  (+0.0%)
sites-dashboard                   +17 B  (+0.0%)      +13 B  (+0.0%)
site-tools                        +17 B  (+0.0%)      +13 B  (+0.0%)
site-settings                     +17 B  (+0.0%)      +13 B  (+0.0%)
site-performance                  +17 B  (+0.0%)      +13 B  (+0.0%)
site-monitoring                   +17 B  (+0.0%)      +13 B  (+0.0%)
site-marketing                    +17 B  (+0.0%)      +13 B  (+0.0%)
site-logs                         +17 B  (+0.0%)      +13 B  (+0.0%)
hosting-features                  +17 B  (+0.0%)      +13 B  (+0.0%)
github-deployments                +17 B  (+0.0%)      +13 B  (+0.0%)
a8c-for-agencies-sites            +17 B  (+0.0%)       +9 B  (+0.0%)
a8c-for-agencies-referrals        +17 B  (+0.0%)       +8 B  (+0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@Imran92 Imran92 force-pushed the fix/email-upsell-site-context branch from 4ac7e8d to dedfef6 Compare January 9, 2025 20:42
@matticbot
Copy link
Contributor

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • notifications
  • wpcom-block-editor

To test WordPress.com changes, run install-plugin.sh $pluginSlug fix/email-upsell-site-context on your sandbox.

Copy link
Contributor

@bogiii bogiii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and everything works as described. 👍

@Imran92 Imran92 force-pushed the fix/site-overview-in-site-context branch 2 times, most recently from b857ee1 to bf0e24b Compare January 10, 2025 12:54
@Imran92 Imran92 force-pushed the fix/email-upsell-site-context branch from 7c2a985 to 8738a43 Compare January 10, 2025 14:42
@Imran92 Imran92 merged commit 9b70157 into fix/site-overview-in-site-context Jan 13, 2025
11 checks passed
@Imran92 Imran92 deleted the fix/email-upsell-site-context branch January 13, 2025 08:01
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Jan 13, 2025
Imran92 added a commit that referenced this pull request Jan 13, 2025
* Hide header when needed

* Use site context param to hide header in flyout view

* Move style to be loaded in all views

* Fix top border after removing header

* Fix wrong page context opening when flag enabled

* Fix rebase error

* Fix email upsell page styles in site context (#98152)

* Move style to be loaded in all views

* Fix email upsell page styles in site context

* Fix context menu not loading

* Fix unit test failing

* Fix scroll spacing issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants