-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix email upsell page styles in site context #98152
Fix email upsell page styles in site context #98152
Conversation
Jetpack Cloud live (direct link)
Automattic for Agencies live (direct link)
|
Here is how your PR affects size of JS and CSS bundles shipped to the user's browser: Sections (~123 bytes added 📈 [gzipped])
Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to. Legend What is parsed and gzip size?Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory. Generated by performance advisor bot at iscalypsofastyet.com. |
4ac7e8d
to
dedfef6
Compare
This PR modifies the release build for the following Calypso Apps: For info about this notification, see here: PCYsg-OT6-p2
To test WordPress.com changes, run |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested and everything works as described. 👍
b857ee1
to
bf0e24b
Compare
7c2a985
to
8738a43
Compare
* Hide header when needed * Use site context param to hide header in flyout view * Move style to be loaded in all views * Fix top border after removing header * Fix wrong page context opening when flag enabled * Fix rebase error * Fix email upsell page styles in site context (#98152) * Move style to be loaded in all views * Fix email upsell page styles in site context * Fix context menu not loading * Fix unit test failing * Fix scroll spacing issue
Related to #97961
and #97962
Proposed Changes
Why are these changes being made?
Testing Instructions
window.sessionStorage.setItem('flags', 'calypso/all-domain-management')
Screen.Recording.2025-01-09.at.8.38.48.PM.mov
Pre-merge Checklist