-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Domains management: Adjust EmailHome component for hosting-overview context #98227
Conversation
Jetpack Cloud live (direct link)
Automattic for Agencies live (direct link)
|
This PR modifies the release build for the following Calypso Apps: For info about this notification, see here: PCYsg-OT6-p2
To test WordPress.com changes, run |
Here is how your PR affects size of JS and CSS bundles shipped to the user's browser: Sections (~11 bytes added 📈 [gzipped])
Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to. Legend What is parsed and gzip size?Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory. Generated by performance advisor bot at iscalypsofastyet.com. |
@@ -105,7 +105,7 @@ const EmailHome = ( props: EmailManagementHomeProps ) => { | |||
return canCurrentUser( state, selectedSite.ID, 'manage_options' ); | |||
} ); | |||
const hasSitesLoaded = useSelector( hasLoadedSites ); | |||
const isAllDomainManagementContext = context === 'domains'; | |||
const isAllDomainManagementContext = context === 'domains' || context === 'hosting-overview'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey 👋 This part is already handled under #98152, as that's already approved, should we leave it to be handled there?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @bogiii 👋 Can you kindly do a rebase with trunk so that we can make sure everything looks good with the layout changes? |
5972465
to
129e404
Compare
Done! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works great! Thanks!
Related to #97963
Proposed Changes
site-context
Why are these changes being made?
Testing Instructions
window.sessionStorage.setItem('flags', 'calypso/all-domain-management')
calypso.localhost:3000/sites
and open this site in flyoutPre-merge Checklist