Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Domains management: Adjust EmailHome component for hosting-overview context #98227

Merged
merged 1 commit into from
Jan 13, 2025

Conversation

bogiii
Copy link
Contributor

@bogiii bogiii commented Jan 10, 2025

Related to #97963

Proposed Changes

  • Adjust the EmailHome component to support site-context

Why are these changes being made?

  • Domain Management Revamp

Testing Instructions

  • Enable the feature flag by window.sessionStorage.setItem('flags', 'calypso/all-domain-management')
  • Purchase a blog domain and attach a site with it.
  • Add at least one google mailbox with the domain
  • Now go to calypso.localhost:3000/sites and open this site in flyout
  • Scroll to bottom and click on the row to open the domain in site context
  • Switch to the Emails tab
  • Ensure the page looks the same as when it's not in site-context
  • Check domains with Titan, Google, and no mailboxes
Screenshot 2025-01-10 at 18 18 18 Screenshot 2025-01-10 at 18 19 17 Screenshot 2025-01-10 at 18 19 50

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
    • For UI changes, have we tested the change in various languages (for example, ES, PT, FR, or DE)? The length of text and words vary significantly between languages.
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@bogiii bogiii requested a review from a team January 10, 2025 17:16
@bogiii bogiii self-assigned this Jan 10, 2025
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Jan 10, 2025
@matticbot
Copy link
Contributor

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • notifications
  • wpcom-block-editor

To test WordPress.com changes, run install-plugin.sh $pluginSlug update/domains-management-email-14 on your sandbox.

@bogiii bogiii marked this pull request as ready for review January 10, 2025 17:24
@bogiii bogiii requested a review from a team as a code owner January 10, 2025 17:24
@matticbot
Copy link
Contributor

matticbot commented Jan 10, 2025

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~11 bytes added 📈 [gzipped])

name     parsed_size           gzip_size
hosting        +26 B  (+0.0%)      +11 B  (+0.0%)
email          +26 B  (+0.0%)      +11 B  (+0.0%)
domains        +26 B  (+0.0%)      +11 B  (+0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@@ -105,7 +105,7 @@ const EmailHome = ( props: EmailManagementHomeProps ) => {
return canCurrentUser( state, selectedSite.ID, 'manage_options' );
} );
const hasSitesLoaded = useSelector( hasLoadedSites );
const isAllDomainManagementContext = context === 'domains';
const isAllDomainManagementContext = context === 'domains' || context === 'hosting-overview';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey 👋 This part is already handled under #98152, as that's already approved, should we leave it to be handled there?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @Imran92 ,

This part is the same, but one is missing from your PR #98152.

https://github.com/Automattic/wp-calypso/pull/98227/files#diff-c09ac2a6897a0f768fcc09a50158e5c57926fdf1a0cffd531403c2755d72f823R104

So we need it as well in order to show it properly for the hosting-overview context.

@bogiii bogiii requested a review from Imran92 January 13, 2025 11:19
@Imran92
Copy link
Contributor

Imran92 commented Jan 13, 2025

Hi @bogiii 👋 Can you kindly do a rebase with trunk so that we can make sure everything looks good with the layout changes?

@bogiii bogiii force-pushed the update/domains-management-email-14 branch from 5972465 to 129e404 Compare January 13, 2025 11:33
@bogiii
Copy link
Contributor Author

bogiii commented Jan 13, 2025

Can you kindly do a rebase with trunk so that we can make sure everything looks good with the layout changes?

Done!

Copy link
Contributor

@Imran92 Imran92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great! Thanks!

@bogiii bogiii merged commit 747583c into trunk Jan 13, 2025
11 checks passed
@bogiii bogiii deleted the update/domains-management-email-14 branch January 13, 2025 15:21
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Jan 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants