Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Issue] Dependency on Avalonia.ReactiveUI #117

Closed
CrackAndDie opened this issue Feb 10, 2024 · 1 comment · Fixed by #118
Closed

[Issue] Dependency on Avalonia.ReactiveUI #117

CrackAndDie opened this issue Feb 10, 2024 · 1 comment · Fixed by #118
Assignees
@DamianSuess
Labels
enhancement New feature or request
Milestone
Avalonia v11.0

Comments

@CrackAndDie
Copy link
Contributor

Description

I use Prism.Avalonia library and do not want to use the ReactiveUI. This is quite strange why do the library needs Avalonia.ReactiveUI

Environment

  • OS: Windows 10
  • Prism.Avalonia Version: 8.1.97.11000
  • Avalonia Version: 11.0.5

Severity (1-5)

3

Steps To Reproduce

Steps to reproduce the behavior:

  1. Add the reference to PrismAvalonia to your project
  2. There would be also the Avalonia.ReactiveUI linked

Expected Behavior

I expect the Prism.Avalonia to be independent from Avalonia.ReactiveUI

Screenshots

Additional context
@CrackAndDie CrackAndDie added the enhancement New feature or request label Feb 10, 2024
@DamianSuess
Copy link
Collaborator

Thank you for reaching out, @CrackAndDie.

I'll review your PR #118

@DamianSuess DamianSuess linked a pull request Apr 8, 2024 that will close this issue
Removed the Avalonia.ReactiveUI dependency #118
Merged
@DamianSuess DamianSuess added this to the Avalonia v11.0 milestone Apr 8, 2024
@DamianSuess DamianSuess self-assigned this Apr 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DamianSuess DamianSuess

Labels
enhancement New feature or request
Projects
None yet
Milestone
Avalonia v11.0
Development

Successfully merging a pull request may close this issue.

Removed the Avalonia.ReactiveUI dependency CrackAndDie/Prism.Avalonia
2 participants
@DamianSuess @CrackAndDie