Removed the Avalonia.ReactiveUI dependency #118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed the dependency and replaced some stuff with internal code
|
For this PR, may you update the description of this PR to explain, "added some required implementations", and include a unit test for the functionality to ensure we are getting the expected behaviors. This assists future readers of this PR to understand what was changed and how it affects the library. |
|
Just updated the description of the RP |
…servableExtensions is internal now and visible only for Tests
|
You can also look at https://github.com/devlooped/RxFree which are source only reactive extensions with the basic feature of System.Reactive, so you don't have to reimplement the helpers. The extensions also will be internal to your project so consumers won't see them. |
|
This will be merged in shortly. Sorry for the delay, had to tend to other repos over the past couple weeks |
|
All set |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Vanilla Prism doesn't have dependencies on libraries like the ReactiveUI (libraries that help us to create UI with code weaving). So I think that Prism.Avalonia also should not use it.
The only thing used in ReactiveUI was subscribing on IObservable interface implementations with lambda methods. In my opinion this is innormal to depend on the library and use only a thing.
So now there is a AnonymousObserver implementation taken from ReactiveUI and ObservableExtensions that gives us the Subscribe method for IObservables.
Tests added :)