Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

env variable is added to auth #120

Closed
wants to merge 0 commits into from
Closed

env variable is added to auth #120

wants to merge 0 commits into from

Conversation

Sushanth-Hebri
Copy link

Auth key is added with env variable

Copy link

vercel bot commented Jun 14, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
chanakya ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 15, 2024 8:04am

Copy link

Thank you for submitting your pull request! We'll review it as soon as possible. For further communication, join our discord server https://discord.gg/tSqtvHUJzE.

@Sushanth-Hebri
Copy link
Author

Environment variable used "REACT_APP_API_KEY" ,
add .env file to .gitignore

.env Outdated
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Sushanth-Hebri still this key will be visible. So, you have to delete this file. I will add this key in deployement env variables. and resolve the conflicts.

@@ -13,7 +13,7 @@ const QuoteSection = () => {
try {
const response = await fetch('https://api.yourquoteapi.com/quotes?author=Chanakya', {
headers: {
'Authorization': `4fe303f4bamshb97ef5b1dd575e0p1ccc51jsnd9644d3c587b`
'Authorization': process.env.REACT_APP_API_KEY
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

named it QUOTES_API_KEY

@Avdhesh-Varshney Avdhesh-Varshney added bug 🐛 Something isn't working Requested Changes ⚙️ Some changes have been requested in this PR labels Jun 15, 2024
Copy link

vercel bot commented Jun 15, 2024

@Avdhesh-Varshney is attempting to deploy a commit to the avdheshvarshney's projects Team on Vercel.

A member of the Team first needs to authorize it.

@Sushanth-Hebri
Copy link
Author

solved this in #124 , auth key must start with REACT_APP for safety , for custom key there need to be separate wired config ,
now auth key is REACT_APP_QUOTES_API_KEY

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something isn't working Requested Changes ⚙️ Some changes have been requested in this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants