auth key must start with REACT_APP for safety crutiny , now auth key is REACT_APP_QUOTES_API_KEY #124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Sushanth-Hebri is attempting to deploy a commit to the avdheshvarshney's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
Thank you for submitting your pull request! We'll review it as soon as possible. For further communication, join our discord server https://discord.gg/tSqtvHUJzE. |
Avdhesh-Varshney
requested changes
Jun 16, 2024
| @@ -13,7 +13,7 @@ const QuoteSection = () => { | |||
| try { | |||
| const response = await fetch("https://api.yourquoteapi.com/quotes?author=Chanakya", { | |||
| headers: { | |||
| "Authorization": `4fe303f4bamshb97ef5b1dd575e0p1ccc51jsnd9644d3c587b` | |||
| 'Authorization': process.env.REACT_APP_QUOTES_API_KEY | |||
There was a problem hiding this comment.
@Sushanth-Hebri REACT name in key is not working in production. That's why i told you to change the name to QUOTES_API_KEY
There was a problem hiding this comment.
@Sushanth-Hebri are you working on it? do it within 1 day.
Avdhesh-Varshney
added
bug 🐛
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #114
Auth key must start with prefix of REACT_APP for custom key there is different wired configuration.
now auth key for quotes is REACT_APP_QUOTES_API_KEY