Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Debugging CI old artifacts issue - DO NOT MERGE #1365

Closed
wants to merge 10 commits into from
Closed

Debugging CI old artifacts issue - DO NOT MERGE #1365

wants to merge 10 commits into from

Conversation

benesjan
Copy link
Contributor

@benesjan benesjan commented Aug 2, 2023

Description

...

Checklist:

  • I have reviewed my diff in github, line by line.
  • Every change is related to the PR description.
  • I have linked this pull request to the issue(s) that it resolves.
  • There are no unexpected formatting changes, superfluous debug logs, or commented-out code.
  • The branch has been merged or rebased against the head of its merge target.
  • I'm happy for the PR to be merged at the reviewer's next convenience.

@benesjan benesjan marked this pull request as draft August 2, 2023 10:16
@benesjan benesjan mentioned this pull request Aug 2, 2023
Merged
6 tasks
benesjan added a commit that referenced this pull request Aug 2, 2023
@benesjan
fix: noir contract artifacts generation in CI (#1366)
f715a55 
# Description

In CI we used stale build of contract types because we failed to build
them after generating them. This was causing issues when there was a
change which required re-generating these types. This PR fixes this.

See [this PR](#1365)
for proof that that was the issue.
@benesjan benesjan closed this Aug 2, 2023
@benesjan benesjan deleted the janb/old-artifacts-issue branch August 2, 2023 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
A3
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@benesjan @spalladino