Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: noir contract artifacts generation in CI #1366

Merged
merged 1 commit into from
Aug 2, 2023
Merged

fix: noir contract artifacts generation in CI #1366

merged 1 commit into from
Aug 2, 2023

Conversation

benesjan
Copy link
Contributor

@benesjan benesjan commented Aug 2, 2023 •
edited
Loading

Description

In CI we used stale build of contract types because we failed to build them after generating them. This was causing issues when there was a change which required re-generating these types. This PR fixes this.

See this PR for proof that that was the issue.

Checklist:

  • I have reviewed my diff in github, line by line.
  • Every change is related to the PR description.
  • I have linked this pull request to the issue(s) that it resolves.
  • There are no unexpected formatting changes, superfluous debug logs, or commented-out code.
  • The branch has been merged or rebased against the head of its merge target.
  • I'm happy for the PR to be merged at the reviewer's next convenience.

@benesjan benesjan enabled auto-merge (squash) August 2, 2023 12:21
@benesjan benesjan force-pushed the janb/old-artifacts-in-ci-fix branch from 7652791 to d537d02 Compare August 2, 2023 13:52
@benesjan benesjan force-pushed the janb/old-artifacts-in-ci-fix branch from d537d02 to 2dd22eb Compare August 2, 2023 13:53
LHerskind
LHerskind approved these changes Aug 2, 2023
View reviewed changes
Copy link
Contributor

@LHerskind LHerskind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Glorious

@benesjan benesjan merged commit f715a55 into master Aug 2, 2023
@benesjan benesjan deleted the janb/old-artifacts-in-ci-fix branch August 2, 2023 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LHerskind LHerskind LHerskind approved these changes

@spalladino spalladino spalladino approved these changes

Assignees
No one assigned
Labels
None yet
Projects
A3
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@benesjan @spalladino @LHerskind