-
Notifications
You must be signed in to change notification settings - Fork 297
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(docs): rewriting absolute paths #6511
Conversation
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @signorecello and the rest of your teammates on Graphite |
Benchmark resultsMetrics with a significant change:
Detailed resultsAll benchmarks are run on txs on the This benchmark source data is available in JSON format on S3 here. Proof generationEach column represents the number of threads used in proof generation.
L2 block published to L1Each column represents the number of txs on an L2 block published to L1.
L2 chain processingEach column represents the number of blocks on the L2 chain where each block has 16 txs.
Circuits statsStats on running time and I/O sizes collected for every kernel circuit run across all benchmarks.
Stats on running time collected for app circuits
Tree insertion statsThe duration to insert a fixed batch of leaves into each tree type.
MiscellaneousTransaction sizes based on how many contract classes are registered in the tx.
Transaction size based on fee payment method | Metric | | Transaction processing duration by data writes.
|
624ccbc
to
34efdb1
Compare
Docs PreviewHey there! 👋 You can check your preview at https://664f2f4883eecd07d866cb48--aztec-docs-dev.netlify.app |
34088a8
to
eded443
Compare
23d6590
to
01bea69
Compare
eded443
to
5755f1f
Compare
01bea69
to
60c6d3e
Compare
5755f1f
to
8e696e2
Compare
60c6d3e
to
1b4dd27
Compare
8e696e2
to
952c4ef
Compare
1b4dd27
to
5092fe1
Compare
952c4ef
to
7039534
Compare
7039534
to
8298ee8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are relative paths better than absolute?
If a file is moved, its contained links with relative paths would need to be updated, but with absolute paths they wouldn't.
That was both my reasoning to do it, and also the easiest way out of the refactor mess, but @jzaki made me see the light:
Took me a while to write that script to rewrite the paths, mostly because of the regex. ChatGPT was useless so I ended up writing it myself. But relative links seem the right thing to do in docusaurus. |
I did the quadrant breakdown in slack regarding paths/urls, relative/absolute. And linked to the docusaurus docs on links and versioning. Dont recall where it's captured, but relative file paths make sense within a section, and absolute file paths make sense between sections. |
f16267f
to
0274c09
Compare
ab4e7a0
to
39b2ea9
Compare
Changes to circuit sizes
🧾 Summary (100% most significant diffs)
Full diff report 👇
|
Merge activity
|
Please read contributing guidelines and remove this line.