Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(docs): zp's nits #6608

Merged
merged 5 commits into from
May 29, 2024
Merged

chore(docs): zp's nits #6608

merged 5 commits into from
May 29, 2024

Conversation

signorecello
Copy link
Contributor

@signorecello signorecello commented May 22, 2024

Entering some friendly competition with dear @catmcgee on nits PRs

Copy link
Contributor Author

signorecello commented May 22, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @signorecello and the rest of your teammates on Graphite Graphite

@signorecello signorecello changed the title nits chore(docs): zp's nits May 22, 2024
@signorecello signorecello marked this pull request as ready for review May 22, 2024 16:48
@AztecBot
Copy link
Collaborator

AztecBot commented May 22, 2024

Docs Preview

Hey there! 👋 You can check your preview at https://6654bdbd2471bd077f2ac3a8--aztec-docs-dev.netlify.app

@AztecBot
Copy link
Collaborator

AztecBot commented May 22, 2024

Benchmark results

No metrics with a significant change found.

Detailed results

All benchmarks are run on txs on the Benchmarking contract on the repository. Each tx consists of a batch call to create_note and increment_balance, which guarantees that each tx has a private call, a nested private call, a public call, and a nested public call, as well as an emitted private note, an unencrypted log, and public storage read and write.

This benchmark source data is available in JSON format on S3 here.

Proof generation

Each column represents the number of threads used in proof generation.

Metric 1 threads 4 threads 16 threads 32 threads 64 threads
proof_construction_time_sha256 5,646 (-1%) 1,556 (+1%) 710 (-1%) 769 (-1%) 773

L2 block published to L1

Each column represents the number of txs on an L2 block published to L1.

Metric 8 txs 32 txs 64 txs
l1_rollup_calldata_size_in_bytes 1,412 1,412 1,412
l1_rollup_calldata_gas 9,452 9,476 9,476
l1_rollup_execution_gas 616,093 616,117 616,117
l2_block_processing_time_in_ms 1,297 4,831 (+1%) 9,645 (+2%)
l2_block_building_time_in_ms 44,991 178,057 356,092
l2_block_rollup_simulation_time_in_ms 44,823 177,429 354,850
l2_block_public_tx_process_time_in_ms 24,171 (-1%) 101,008 206,559

L2 chain processing

Each column represents the number of blocks on the L2 chain where each block has 16 txs.

Metric 3 blocks 5 blocks
node_history_sync_time_in_ms 9,575 (+1%) 14,481
node_database_size_in_bytes 14,467,152 21,368,912
pxe_database_size_in_bytes 18,071 29,868

Circuits stats

Stats on running time and I/O sizes collected for every kernel circuit run across all benchmarks.

Circuit simulation_time_in_ms witness_generation_time_in_ms proving_time_in_ms input_size_in_bytes output_size_in_bytes proof_size_in_bytes num_public_inputs size_in_gates
private-kernel-init 160 (-1%) 3,592 (+1%) 25,134 (-6%) 20,630 64,614 89,536 2,731 1,048,576
private-kernel-inner 626 (-1%) 4,092 (+1%) 50,212 (-2%) 92,318 64,614 89,536 2,731 2,097,152
private-kernel-tail 571 (-1%) 2,794 43,665 96,541 77,498 10,656 266 2,097,152
base-parity 6.44 (-1%) 1,233 (+8%) 2,796 (-1%) 128 64.0 2,208 2.00 131,072
root-parity 49.0 60.9 (-8%) 52,511 (+3%) 27,084 64.0 2,720 18.0 2,097,152
base-rollup 735 (+5%) 2,341 (-3%) 84,940 119,610 756 3,648 47.0 4,194,304
root-rollup 110 75.1 (-6%) 22,665 (-4%) 25,297 620 3,456 41.0 1,048,576
public-kernel-app-logic 526 2,920 (-3%) 52,450 104,941 86,302 114,784 3,520 2,097,152
public-kernel-tail 1,086 (-1%) 23,847 (+11%) 184,635 (+3%) 395,386 7,522 10,656 266 8,388,608
private-kernel-reset-small 594 (-1%) 1,955 (+1%) 49,008 (-2%) 120,733 64,614 89,536 2,731 2,097,152
merge-rollup 28.6 N/A N/A 16,534 756 N/A N/A N/A
public-kernel-setup 626 (-2%) N/A N/A 104,941 86,302 N/A N/A N/A
public-kernel-teardown 526 (-2%) N/A N/A 104,941 86,302 N/A N/A N/A
private-kernel-tail-to-public N/A 8,386 (+1%) 107,886 (-2%) N/A N/A 114,784 3,520 4,194,304

Stats on running time collected for app circuits

Function input_size_in_bytes output_size_in_bytes witness_generation_time_in_ms proof_size_in_bytes proving_time_in_ms size_in_gates num_public_inputs
ContractClassRegisterer:register 1,344 9,944 465 (+1%) N/A N/A N/A N/A
ContractInstanceDeployer:deploy 1,408 9,944 41.1 N/A N/A N/A N/A
MultiCallEntrypoint:entrypoint 1,920 9,944 1,439 (+2%) N/A N/A N/A N/A
SchnorrAccount:constructor 1,312 9,944 1,011 (+4%) N/A N/A N/A N/A
SchnorrAccount:entrypoint 2,304 9,944 2,088 16,768 54,716 (-2%) 2,097,152 457
Token:privately_mint_private_note 1,280 9,944 1,093 N/A N/A N/A N/A
Token:transfer 1,376 9,944 4,001 16,768 55,711 (-6%) 2,097,152 457
Benchmarking:create_note 1,312 9,944 952 N/A N/A N/A N/A
FPC:fee_entrypoint_public 1,344 9,944 222 N/A N/A N/A N/A
SchnorrAccount:spend_private_authwit 1,280 9,944 77.8 N/A N/A N/A N/A
Token:unshield 1,376 9,944 3,241 N/A N/A N/A N/A
FPC:fee_entrypoint_private 1,376 9,944 4,022 N/A N/A N/A N/A

Tree insertion stats

The duration to insert a fixed batch of leaves into each tree type.

Metric 1 leaves 16 leaves 64 leaves 128 leaves 512 leaves 1024 leaves 2048 leaves 4096 leaves 32 leaves
batch_insert_into_append_only_tree_16_depth_ms 10.4 16.9 N/A N/A N/A N/A N/A N/A N/A
batch_insert_into_append_only_tree_16_depth_hash_count 16.7 31.8 N/A N/A N/A N/A N/A N/A N/A
batch_insert_into_append_only_tree_16_depth_hash_ms 0.603 (-1%) 0.518 N/A N/A N/A N/A N/A N/A N/A
batch_insert_into_append_only_tree_32_depth_ms N/A N/A 49.3 (+2%) 76.4 (-1%) 247 476 (+1%) 929 1,859 (+1%) N/A
batch_insert_into_append_only_tree_32_depth_hash_count N/A N/A 95.9 159 543 1,055 2,079 4,127 N/A
batch_insert_into_append_only_tree_32_depth_hash_ms N/A N/A 0.503 (+2%) 0.470 (-1%) 0.448 0.444 (+1%) 0.440 0.442 (+1%) N/A
batch_insert_into_indexed_tree_20_depth_ms N/A N/A 58.6 113 (+1%) 358 (+1%) 700 (+1%) 1,391 (+1%) 2,788 (+1%) N/A
batch_insert_into_indexed_tree_20_depth_hash_count N/A N/A 106 208 692 1,363 2,707 5,395 N/A
batch_insert_into_indexed_tree_20_depth_hash_ms N/A N/A 0.507 (+1%) 0.506 (+1%) 0.483 0.481 (+1%) 0.479 0.483 (+1%) N/A
batch_insert_into_indexed_tree_40_depth_ms N/A N/A N/A N/A N/A N/A N/A N/A 62.6 (+1%)
batch_insert_into_indexed_tree_40_depth_hash_count N/A N/A N/A N/A N/A N/A N/A N/A 107
batch_insert_into_indexed_tree_40_depth_hash_ms N/A N/A N/A N/A N/A N/A N/A N/A 0.555 (+1%)

Miscellaneous

Transaction sizes based on how many contract classes are registered in the tx.

Metric 0 registered classes 1 registered classes
tx_size_in_bytes 83,794 665,117

Transaction size based on fee payment method

| Metric | |
| - | |

@signorecello signorecello force-pushed the zpedro/docs_relative_urls branch from ab4e7a0 to 39b2ea9 Compare May 23, 2024 11:50
@signorecello signorecello force-pushed the zpedro/docs_cleanup branch from 4d75eab to 6da77c0 Compare May 23, 2024 11:50
Base automatically changed from zpedro/docs_relative_urls to master May 23, 2024 12:12
@signorecello signorecello force-pushed the zpedro/docs_cleanup branch from 6da77c0 to 669a874 Compare May 23, 2024 14:55
Copy link
Contributor Author

signorecello commented May 29, 2024

Merge activity

@signorecello signorecello merged commit defd2ba into master May 29, 2024
85 checks passed
@signorecello signorecello deleted the zpedro/docs_cleanup branch May 29, 2024 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants