Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(dsl): ecdsa secp256r1 acvm bindings (noir master) #576

Merged
merged 7 commits into from
Jul 8, 2023
Merged

feat(dsl): ecdsa secp256r1 acvm bindings (noir master) #576

merged 7 commits into from
Jul 8, 2023

Conversation

Maddiaa0
Copy link
Member

@Maddiaa0 Maddiaa0 commented Jul 4, 2023

Description

Adds support for secp256r1 for noir, following the template for k1.

Checklist:

  • I have reviewed my diff in github, line by line.
  • Every change is related to the PR description.
  • The branch has been merged with/rebased against the head of its merge target.
  • There are no unexpected formatting changes, superfluous debug logs, or commented-out code.
  • There are no circuit changes, OR a cryptographer has been assigned for review.
  • New functions, classes, etc. have been documented according to the doxygen comment format. Classes and structs must have @brief describing the intended functionality.
  • If existing code has been modified, such documentation has been added or updated.
  • No superfluous include directives have been added.
  • I have linked to any issue(s) it resolves.
  • I'm happy for the PR to be merged at the reviewer's next convenience.

@Maddiaa0 Maddiaa0 changed the title feat(dsl): ecdsa secp256r1 acvm bindings feat(dsl): ecdsa secp256r1 acvm bindings (noir master) Jul 4, 2023
@Maddiaa0 Maddiaa0 mentioned this pull request Jul 4, 2023
Merged
2 tasks
@Maddiaa0 Maddiaa0 requested review from kevaundray and vezenovm July 5, 2023 14:35
@Maddiaa0 Maddiaa0 marked this pull request as ready for review July 5, 2023 14:36
@kevaundray kevaundray merged commit 32f03dc into acvm-backend-barretenberg Jul 8, 2023
@kevaundray kevaundray deleted the md/hacka branch July 8, 2023 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevaundray kevaundray Awaiting requested review from kevaundray

@vezenovm vezenovm Awaiting requested review from vezenovm

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Maddiaa0 @kevaundray