This repository has been archived by the owner on Apr 9, 2024. It is now read-only.
feat(acir)!: add EcdsaSecp256r1 blackbox function
#408
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you implement this in Brillig at the same time? #401 |
TomAFrench
changed the title
EcdsaSecp256r1 blackbox function
2 tasks
vezenovm
reviewed
Jul 5, 2023
TomAFrench
previously requested changes
Jul 5, 2023
There was a problem hiding this comment.
Spoke with @kevaundray and he wants to hold this to go out after 0.16.0
kevaundray
changed the title
EcdsaSecp256r1 blackbox functionEcdsaSecp256r1 blackbox function
kevaundray
approved these changes
Jul 7, 2023
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds support for the secp256 r1 curve through a black box function.
Related prs:
acvm-backend-barretenberg: noir-lang/acvm-backend-barretenberg#223
barretenberg: AztecProtocol/barretenberg#576
Problem*
Resolves
Summary*
Additional Context
PR Checklist*
cargo fmton default settings.