Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed generation of policySetDefinitions and improved whatif error handling #423

Merged
merged 2 commits into from
Sep 9, 2021
Merged

Changed generation of policySetDefinitions and improved whatif error handling #423

merged 2 commits into from
Sep 9, 2021

Conversation

daltondhcp
Copy link
Contributor

Overview/Summary

Closing #418 and #396

This PR fixes/adds/changes/removes

  1. Changed so policySetDefinitions generate parameter files instead of regular deployment templates to overcome escaping issues (Policy initiative with parameters will fail. #418)
  2. Improved WhatIf/Validate error handling to throw terminating errors on template errors (Failure during validate marks task as succeeded (treat warnings as errors) #396)

As part of this Pull Request I have

  • Checked for duplicate Pull Requests
  • Associated it with relevant issues, for tracking and closure.
  • Ensured my code/branch is up-to-date with the latest changes in the main branch
  • Performed testing and provided evidence.
  • Updated relevant and associated documentation.
  • Updated the "What's New?" wiki page (located in the Enterprise-Scale repo in the directory: /docs/wiki/whats-new.md)

@daltondhcp daltondhcp requested a review from a team as a code owner September 9, 2021 12:06
@daltondhcp
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Member

@ljtill ljtill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@daltondhcp daltondhcp merged commit e6b5a77 into Azure:main Sep 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants