Skip to content

Commit

Permalink
Fixing Dragos arm-ttk id from resourceId validation errors (#11726)
Browse files Browse the repository at this point in the history
* Mitigating arm-ttk errors that docs say we can ignore, but partner center submission rejects.

* Fixing custom detail as id bypass resulted in name that was too long

* Bumping analytic version due to id name field change.

* Solution packaged

---------

Co-authored-by: v-prasadboke <v-prasadboke@microsoft.com>
  • Loading branch information
dragosinc-sentinel and v-prasadboke authored Feb 3, 2025
1 parent 1838656 commit 03d2380
Show file tree
Hide file tree
Showing 6 changed files with 36 additions and 36 deletions.
6 changes: 3 additions & 3 deletions Solutions/Dragos/Analytic Rules/DragosNotifiction.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ alertDetailsOverride:
- alertProperty: ProductName
value: AlertProductName
customDetails:
DragosNotificationId: id
DragosIdentifier: id
DragosSeverity: severity
DragosDetectionQuads: detectionQuads
DragosCreatedAt: createdAt
Expand All @@ -60,6 +60,6 @@ incidentConfiguration:
lookbackDuration: PT1H
matchingMethod: Selected
groupByCustomDetails:
- DragosNotificationId
version: 1.0.0
- DragosIdentifier
version: 1.0.1
kind: Scheduled
Binary file modified Solutions/Dragos/Package/3.0.0.zip
Binary file not shown.
60 changes: 30 additions & 30 deletions Solutions/Dragos/Package/mainTemplate.json

Large diffs are not rendered by default.

Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ FunctionQuery: |
let existingIncidents = SecurityAlert
| where ProductName == "Dragos"
| extend CustomDetails=tostring(parse_json(ExtendedProperties)["Custom Details"])
| extend id = toint(extract_json("$.DragosNotificationId[0]", CustomDetails))
| extend id = toint(extract_json("$.DragosIdentifier[0]", CustomDetails))
| project-keep SystemAlertId, id;
union isfuzzy=true DragosPushNotificationsToSentinel, DragosPullNotificationsToSentinel
| join kind=leftouter (existingIncidents) on id
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ FunctionQuery: |
let existingIncidents = SecurityAlert
| where ProductName == "Dragos"
| extend CustomDetails=tostring(parse_json(ExtendedProperties)["Custom Details"])
| extend id = toint(extract_json("$.DragosNotificationId[0]", CustomDetails))
| extend id = toint(extract_json("$.DragosIdentifier[0]", CustomDetails))
| project-keep SystemAlertId, id;
DragosAlerts_CL
| extend detectionQuads=strcat_array(detectionQuads, ",")
Expand Down
2 changes: 1 addition & 1 deletion Solutions/Dragos/SolutionMetadata.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"publisherId": "dragosinc1734451815609",
"offerId": "azure-sentinel-solution-dragos",
"offerId": "microsoft-sentinel-solution-dragos",
"firstPublishDate": "2025-01-23",
"lastPublishDate": "2025-01-23",
"providers": [
Expand Down

0 comments on commit 03d2380

Please sign in to comment.