Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing Dragos arm-ttk id from resourceId validation errors #11726

Merged
merged 6 commits into from
Feb 3, 2025

Conversation

dragosinc-sentinel
Copy link
Contributor

Required items, please complete

Change(s):

  • Updating various resource IDs to conform to best practices for ARM templates

Reason for Change(s):

  IDs Should Be Derived From ResourceIDs
    [-] IDs Should Be Derived From ResourceIDs (109 ms)
        Property: "id" must use one of the following expressions for an resourceId property:
          extensionResourceId,resourceId,subscriptionResourceId,tenantResourceId,if,parameters,reference,variables,subscription,guid

Version Updated:

  • Required only for Detections/Analytic Rule templates
  • See guidance below

Testing Completed:

Checked that the validations are passing and have addressed any issues that are present:

  • Yes

@dragosinc-sentinel dragosinc-sentinel marked this pull request as ready for review January 28, 2025 02:44
@dragosinc-sentinel dragosinc-sentinel requested review from a team as code owners January 28, 2025 02:44
@v-prasadboke v-prasadboke self-assigned this Jan 28, 2025
@v-prasadboke v-prasadboke added the Solution Solution specialty review needed label Jan 28, 2025
@dragosinc-sentinel
Copy link
Contributor Author

Any updates @v-prasadboke ?

@dragosinc-sentinel
Copy link
Contributor Author

The detections validation PR check is failing but I don't see how it relates to any of the changes that I made. Looking at other runs of this check, it seems to have issues when the PR comes from a branch that is not part of the main Azure/Azure-Sentinel repo as show below:

Can you please advise?

@v-prasadboke
Copy link
Contributor

Hello @dragosinc-sentinel, failure for id is an exception. We can ignore it.

I have packaged the solution now

@v-prasadboke
Copy link
Contributor

Looks good

@rahul0216 rahul0216 merged commit 03d2380 into Azure:master Feb 3, 2025
33 of 34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Solution Solution specialty review needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants