Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve discovery docs #3

Closed
matt-FFFFFF opened this issue Jun 15, 2020 · 1 comment
Closed

Improve discovery docs #3

matt-FFFFFF opened this issue Jun 15, 2020 · 1 comment
Labels
bug Something isn't working

Comments

@matt-FFFFFF
Copy link
Member

The code examples for discovery have the default username still embedded and also involve unnecessary repetition.

PR incoming.
@matt-FFFFFF matt-FFFFFF mentioned this issue Jun 15, 2020
Closed
@matt-FFFFFF
Copy link
Member Author

Changes incorporated when rewriting history

@ljtill ljtill added the bug Something isn't working label Jun 18, 2020
krnese added a commit that referenced this issue May 13, 2021
@krnese
FAQ Update (#565)
bbd033f 
* update #1

* Update #2

* Update #3
krnese added a commit that referenced this issue Jul 13, 2021
@krnese @daltondhcp
adding ARM modules (#613)
e411a85 
* adding modules

* defined contract

* update #3

* added enforcementMode param

* adding param

* UX and contract changes

* conditional firewall for hub vs vwan

* support for single vs N platform subs

* updated UX for single vs dedicated platform subscriptions

* updating built-in policy

* correcting parameter

* navigating policies for identity

* adding vwan and nva for networking

* removing peering

* adding scaleUnit for vpnGateway and ER for vwan

* fixing parameter

* adding disclaimer for sub selection

* adding private dns zones and moving to built-in policies

* adding policySet for DINE Private DNS Zones

* Added policyset for public paas

* removed custom references

* Update Deny-PublicEndpointsPolicySetDefinition.json

* policy updates

* adding policies and UX enhancements

* removing option for private dns zones when vwan is selected

* adding UX for vnet peering of dedicated ID sub

* adding peering for identity sub

* adding vnet peering for corp lz

* corp lz move and peering

* sequencing corp lz move vs peering

* updated description and displayName

* updating rg location for nw

* adding condition for AzFw as DNS proxy vs not

* adding peering support for identity to vwan hub

* updating displayName

Co-authored-by: Johan Dahlbom <johan@dahlbom.eu>
krnese pushed a commit that referenced this issue Jul 14, 2021
@github-actions
System commit (#3)
c389701 
Co-authored-by: AzOps <noreply@azure.com>
@ghost ghost locked as resolved and limited conversation to collaborators Jan 12, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Improve code to trigger repo dispatch
2 participants
@ljtill @matt-FFFFFF