Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes bug with ama role assignments #1593

Merged
merged 6 commits into from
Mar 8, 2024
Merged

Conversation

arjenhuitema
Copy link
Contributor

@arjenhuitema arjenhuitema commented Mar 6, 2024

Overview/Summary

Resolved an issue that prevented the policy remediation from working properly for VM Insights and Change Tracking policies. The root cause was the insufficient access granted to the Managed Identity that performs the remediation task. To solve the problem, we granted the Policy Assignments in the Landing Zone Management the permission to read the Platform Management Group.

This PR fixes/adds/changes/removes

  1. Adds Role Assignments to VMInsights Policies at LZs MG granting rbacReader on Platform MG
  2. Adds Role Assignments to ChangeTracking Policies at LZs MG granting rbacReader on Platform MG
  3. Adds Role Assignments to Azure Update Manger Policies, granting rbacManagedIdentityOperator at the same scope as the assignment.

Breaking Changes

None

Testing Evidence

Deployment

image

Compliance Monitoring

image

Compliance Change Tracking

image

Compliance Azure Update Manager

image

Testing URLs

Azure Public

Deploy To Azure

As part of this Pull Request I have

  • Checked for duplicate Pull Requests
  • Associated it with relevant issues, for tracking and closure.
  • Ensured my code/branch is up-to-date with the latest changes in the main branch
  • Performed testing and provided evidence.
  • Ensured contribution guidance is followed.
  • Updated relevant and associated documentation.
  • Updated the "What's New?" wiki page (located: /docs/wiki/whats-new.md)

@arjenhuitema arjenhuitema added bug Something isn't working Area: Policy 📝 Issues / PR's related to Policy Area: RBAC 🛂 Issues / PR's related to RBAC labels Mar 6, 2024
@arjenhuitema arjenhuitema requested a review from a team as a code owner March 6, 2024 23:19
docs/wiki/Whats-new.md Outdated Show resolved Hide resolved
docs/wiki/Whats-new.md Outdated Show resolved Hide resolved
@jtracey93 jtracey93 merged commit 59b2ca1 into main Mar 8, 2024
3 of 4 checks passed
@jtracey93 jtracey93 deleted the bug-ama-role-assignments branch March 8, 2024 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Policy 📝 Issues / PR's related to Policy Area: RBAC 🛂 Issues / PR's related to RBAC bug Something isn't working Needs: Author Feedback
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants