Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add policy set definition workaround #1659

Merged
merged 1 commit into from
Jun 5, 2024
Merged

Conversation

jaredfholgate
Copy link
Member

@jaredfholgate jaredfholgate commented Jun 5, 2024

Overview/Summary

This fixes an issue where policy set definitions only reference one policy definition.

I tried various workarounds in the class definitions before resorting this option. It appears there is a fundamental issue in PowerShell that results in needing to fix it like this rather than in the class constructor / definition as you would expect.

This PR fixes/adds/changes/removes

N/A

Breaking Changes

N/A

Testing Evidence

This is a fix to a script library used for policy sync, so does not need portal testing.

You can see a working run based on this branch over here: https://github.com/Azure/terraform-azurerm-caf-enterprise-scale/pull/972/files

As part of this Pull Request I have

  • Checked for duplicate Pull Requests
  • Associated it with relevant issues, for tracking and closure.
  • Ensured my code/branch is up-to-date with the latest changes in the main branch
  • Performed testing and provided evidence.
  • Ensured contribution guidance is followed.
  • Updated relevant and associated documentation.
  • Updated the "What's New?" wiki page (located: /docs/wiki/whats-new.md)

@jtracey93 jtracey93 merged commit 9b578dd into main Jun 5, 2024
4 of 6 checks passed
@jtracey93 jtracey93 deleted the fix-json-serialization-bug branch June 5, 2024 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants