Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New custom policy DenyAction Delete UAMI used by AMA #1662

Merged
merged 16 commits into from
Jun 6, 2024

Conversation

arjenhuitema
Copy link
Contributor

@arjenhuitema arjenhuitema commented Jun 5, 2024

Overview/Summary

New custom policy to safeguard against accidental removal of the User Assigned Managed Identity used by AMA by blocking delete calls using deny action effect.

This PR fixes/adds/changes/removes

  1. Adds Policy Definition DenyAction-DeleteResources
  2. Adds Policy Assignment DenyAction-DeleteUAMIAMA
  3. Documentation updates

Breaking Changes

N/A

Testing Evidence

Please provide any testing evidence to show that your Pull Request works/fixes as described and planned (include screenshots, if appropriate).

Deployment:
image

Assignment:
image

Action denied:
image

Testing URLs

Azure Public

Deploy To Azure

As part of this Pull Request I have

  • Checked for duplicate Pull Requests
  • Associated it with relevant issues, for tracking and closure.
  • Ensured my code/branch is up-to-date with the latest changes in the main branch
  • Performed testing and provided evidence.
  • Ensured contribution guidance is followed.
  • Updated relevant and associated documentation.
  • Updated the "What's New?" wiki page (located: /docs/wiki/whats-new.md)

@Springstone Springstone added Area: Diagnostic Settings Area: Policy 📝 Issues / PR's related to Policy Status: PR Safe To Test ☑️ PRs can run deployment tests and removed Area: Diagnostic Settings labels Jun 6, 2024
Copy link
Member

@Springstone Springstone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@arjenhuitema looks, great, some minor text adjustments, kindly review.

docs/wiki/Whats-new.md Outdated Show resolved Hide resolved
docs/wiki/Whats-new.md Outdated Show resolved Hide resolved
docs/wiki/ALZ-Policies.md Outdated Show resolved Hide resolved
…tion-DeleteResources.json

Co-authored-by: Sacha Narinx <Springstone@users.noreply.github.com>
github-actions bot and others added 2 commits June 6, 2024 07:09
…tion-DeleteResources.json

Co-authored-by: Sacha Narinx <Springstone@users.noreply.github.com>
Co-authored-by: Sacha Narinx <Springstone@users.noreply.github.com>
Co-authored-by: Sacha Narinx <Springstone@users.noreply.github.com>
Co-authored-by: Sacha Narinx <Springstone@users.noreply.github.com>
Copy link
Member

@Springstone Springstone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jtracey93 jtracey93 merged commit 0c81c91 into main Jun 6, 2024
3 of 5 checks passed
@jtracey93 jtracey93 deleted the patch-policy-denyaction-uami branch June 6, 2024 07:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Policy 📝 Issues / PR's related to Policy Status: PR Safe To Test ☑️ PRs can run deployment tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants