chore: Update Deploy-ASC-SecurityContacts version to 2.0.0 #1663
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…I and revised construct for Security Contact API in Defender for Cloud
Springstone
added
the
PR: Safe to test 🧪
|
@donk-msft I cannot see the comments on this PR you mention here: #1627 (comment) Can you advise as looking to get this out 👍 |
…I and revised construct for Security Contact API in Defender for Cloud
…rprise-Scale into SecurityContact
donk-msft
reviewed
Jun 7, 2024
src/resources/Microsoft.Authorization/policyDefinitions/Deploy-ASC-SecurityContacts.json
Outdated
Show resolved
Hide resolved
@jtracey93 comments have been addressed by @Springstone in the meantime. No open comments left from my side. |
jtracey93
approved these changes
Jun 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview/Summary
This pull request primarily focuses on updating the
Deploy-ASC-SecurityContacts.jsonpolicy definition in thesrc/resources/Microsoft.Authorization/directory. The key updates include upgrading the version of the policy, modifying the description of the "Security contacts email address" metadata, updating the security contact fields, and changing the API version.Policy Definition Updates:
src/resources/Microsoft.Authorization/policyDefinitions/Deploy-ASC-SecurityContacts.json: The policy version was updated from "1.1.0" to "2.0.0". This suggests a significant update or change in the policy.Metadata Changes:
src/resources/Microsoft.Authorization/policyDefinitions/Deploy-ASC-SecurityContacts.json: The description for the "Security contacts email address" metadata was changed. It now indicates that multiple email addresses separated by semi-colons can be provided for Defender for Cloud contact details.Security Contact Fields:
src/resources/Microsoft.Authorization/policyDefinitions/Deploy-ASC-SecurityContacts.json: Several fields related to security contacts were modified. ThealertNotifications.minimalSeverityandalertsToAdminsfields were removed, while theisEnabledandnotificationsSources[*].Alert.minimalSeverityfields were added. This indicates a shift in how security contacts and alert notifications are managed.API Version Change:
src/resources/Microsoft.Authorization/policyDefinitions/Deploy-ASC-SecurityContacts.json: The API version was updated from "2020-01-01-preview" to "2023-12-01-preview". Additionally, thealertNotificationsproperty was replaced bynotificationsSources, and a newisEnableproperty was added. These changes suggest a significant update to the API and how notifications are handled.This PR fixes/adds/changes/removes
Testing URLs
Azure Public
As part of this Pull Request I have
mainbranch/docs/wiki/whats-new.md)