Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1779 single subscription scenario fails #1782

Merged
merged 4 commits into from
Oct 9, 2024

Conversation

arjenhuitema
Copy link
Contributor

@arjenhuitema arjenhuitema commented Oct 2, 2024

Overview/Summary

This resolves a deployment issue occurring when deploying to a single platform subscription. The AMBA template received incorrect parameters, which mistakenly directed it to deploy to a standard management group structure.

This PR fixes/adds/changes/removes

  1. Updated parameters that define the assignment scope for Management, Identity, and Connectivity policy initiatives within a single-platform subscription setup.
  2. Now, setting the single platform subscription parameter in the AMBA Management Subscription parameter when deployed in such a configuration.

Breaking Changes

None

Testing Evidence

Please provide any testing evidence to show that your Pull Request works/fixes as described and planned (include screenshots, if appropriate).

Single platform management group deployment
image

Standard deployment
image

Testing URLs

Azure Public

Deploy To Azure

As part of this Pull Request I have

  • Checked for duplicate Pull Requests
  • Associated it with relevant issues, for tracking and closure.
  • Ensured my code/branch is up-to-date with the latest changes in the main branch
  • Performed testing and provided evidence.
  • Ensured contribution guidance is followed.
  • Updated relevant and associated documentation.
  • Updated the "What's New?" wiki page (located: /docs/wiki/whats-new.md)

@arjenhuitema arjenhuitema requested a review from a team as a code owner October 2, 2024 20:34
@arjenhuitema arjenhuitema linked an issue Oct 2, 2024 that may be closed by this pull request
Springstone
Springstone previously approved these changes Oct 3, 2024
Copy link
Member

@Springstone Springstone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Springstone Springstone added the PR: Safe to test 🧪 PRs can run more advanced tests that may deploy or access environments label Oct 3, 2024
@jtracey93 jtracey93 added the Test: Standard Standard portal deployment test without networking label Oct 7, 2024
@jtracey93 jtracey93 closed this Oct 7, 2024
@jtracey93 jtracey93 reopened this Oct 7, 2024
@jtracey93 jtracey93 merged commit 0a920e2 into main Oct 9, 2024
3 of 4 checks passed
@jtracey93 jtracey93 deleted the 1779-single-subscription-scenario-fails branch October 9, 2024 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: Safe to test 🧪 PRs can run more advanced tests that may deploy or access environments Test: Standard Standard portal deployment test without networking
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Single subscription scenario fails
3 participants