Fixes deployment validation error when LAW is not deployed, and AMBA is enabled #1820
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…al Accelerator deployment validation
jtracey93
approved these changes
Nov 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview/Summary
Fixes a bug in the Portal Accelerator that causes deployment validation to fail with the error message "The 'location' property must be specified for 'amba-id-amba-prod-001'". This event happens when a Log Analytics Workspace is not deployed, but Azure Monitor Baseline Alerts is enabled. This issue occurs because Azure Monitor Baseline Alerts depends on the management subscription, which is not provided if the Log Analytics Workspace is not deployed. To address this scenario, an additional section was implemented in the Baseline alerts and monitoring tab allowing the selection of a Management subscription when not deploying a Log Analytics Workspace.
This PR fixes/adds/changes/removes
Breaking Changes
None
Testing Evidence
Single subscription with LAW
Deployment
AMBA UAMI deployed to single platform subscription
Single subscription no LAW
Deployment
AMBA UAMI deployed to single platform subscription
Dedicated subscriptions with LAW
Deployment
AMBA UAMI deployed to management subscription
Dedicated subscriptions no LAW, with Management subscription selection in Monitoring section
Deployment
AMBA UAMI deployed to management subscription
Dedicated subscriptions no LAW, no Management subscription selection in Monitoring section
Deployment
In this case the AMBA UAMI is not deployed.
Testing URLs
Azure Public
As part of this Pull Request I have
mainbranch/docs/wiki/whats-new.md)