Merge CGroups into Develop #1555

vrdmr · 2019-06-14T00:55:11Z

Description

Merging the changes from CGroups branch into develop.

Issue #

PR information

The title of the PR is clear and informative.
There are a small number of commits, each of which has an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
If applicable, the PR references the bug/issue that it fixes in the description.
New Unit tests were added for the changes made and Travis.CI is passing.

Quality of Code and Contribution Guidelines

I have read the contribution guidelines.

This change is

* API for extension cgroups * add systemd implemented methods for extensions * fix and improve tests * add comments * add daemon-reload after removing units * code refactoring * fix tests * change how we check systemd * fix updated check for systemd * fix systemd check again * update comment for systemd check * address most CR comments * add unit test for API resolution * address CR comments and add unit tests * revert is_systemd method

* Added unit tests fror CGroupApi * Remove comments

Making cgroup telemetry work end to end, with new spec for metrics

* Added unit tests for CGroupConfigurator * Added test for start_extension_command * Do not mount cgroups

…-enabled

…-cgroups-enabled Adding more unittests to enable cgroup telemetry tests and fixing nit bugs in CGT class.

Create unique scopes for extensions

Also, added a test for empty_cgroup.

Changed the implementation and the unittests for the is_tracked check.

Also scope name is now not created in this PR

Bug fixes for duplicate copies and scope name

Exposed the cgroups.collect exceptions to distinguish difference between incorrect configuration and 0 value.

Preventing incorrect metrics to be sent on telemetry

codecov · 2019-06-14T01:01:23Z

Codecov Report

Merging #1555 into develop will increase coverage by 2.34%.
The diff coverage is 77.9%.

@@             Coverage Diff             @@
##           develop    #1555      +/-   ##
===========================================
+ Coverage    60.89%   63.23%   +2.34%     
===========================================
  Files           75       78       +3     
  Lines        10888    11035     +147     
  Branches      1562     1552      -10     
===========================================
+ Hits          6630     6978     +348     
+ Misses        3943     3719     -224     
- Partials       315      338      +23

Impacted Files	Coverage Δ
azurelinuxagent/common/protocol/wire.py	`69.2% <ø> (ø)`	⬆️
azurelinuxagent/common/exception.py	`91.35% <100%> (+0.33%)`	⬆️
azurelinuxagent/common/logger.py	`88.59% <100%> (+1.18%)`	⬆️
azurelinuxagent/daemon/main.py	`72.91% <100%> (ø)`	⬆️
azurelinuxagent/ga/exthandlers.py	`81.48% <100%> (+0.07%)`	⬆️
azurelinuxagent/ga/update.py	`88.31% <100%> (+0.11%)`	⬆️
azurelinuxagent/common/event.py	`82.69% <100%> (+2.38%)`	⬆️
azurelinuxagent/common/cgroupapi.py	`63.76% <63.76%> (ø)`
azurelinuxagent/common/osutil/default.py	`55.55% <66.66%> (+1.77%)`	⬆️
azurelinuxagent/common/cgroup.py	`69.64% <69.64%> (ø)`
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3323a88...ab9cffe. Read the comment docs.

codecov · 2019-06-14T01:01:23Z

Codecov Report

Merging #1555 into develop will increase coverage by 2.52%.
The diff coverage is 77.9%.

@@             Coverage Diff             @@
##           develop    #1555      +/-   ##
===========================================
+ Coverage    60.89%   63.41%   +2.52%     
===========================================
  Files           75       78       +3     
  Lines        10888    11084     +196     
  Branches      1562     1568       +6     
===========================================
+ Hits          6630     7029     +399     
+ Misses        3943     3718     -225     
- Partials       315      337      +22

Impacted Files	Coverage Δ
azurelinuxagent/common/protocol/wire.py	`70.73% <ø> (+1.53%)`	⬆️
azurelinuxagent/common/exception.py	`91.35% <100%> (+0.33%)`	⬆️
azurelinuxagent/common/logger.py	`88.59% <100%> (+1.18%)`	⬆️
azurelinuxagent/daemon/main.py	`72.91% <100%> (ø)`	⬆️
azurelinuxagent/ga/exthandlers.py	`81.48% <100%> (+0.07%)`	⬆️
azurelinuxagent/ga/update.py	`88.31% <100%> (+0.11%)`	⬆️
azurelinuxagent/common/event.py	`82.69% <100%> (+2.38%)`	⬆️
azurelinuxagent/common/cgroupapi.py	`63.76% <63.76%> (ø)`
azurelinuxagent/common/osutil/default.py	`55.55% <66.66%> (+1.77%)`	⬆️
azurelinuxagent/common/cgroup.py	`69.64% <69.64%> (ø)`
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3323a88...ab9cffe. Read the comment docs.

pgombar

LGTM

narrieta and others added 30 commits May 13, 2019 11:39

Split cgroups.py into smaller files and rename classes. (#1524)

df97eec

Defined API for initialization of cgroups (#1530)

ab8f394

API for extension cgroups (#1533)

8d02446

Do not test Python nightly (#1535)

8309d14

Refactor start_extension_command to CGroupsApi (#1534)

8e537f5

Refactor configurator (#1537)

4da18d3

Making cgroup telemetry work end to end, with new spec

e7d6acb

Fixing the unittests

7120c52

Fixing the telemetry tests for active polling

f8f32c7

Added unit tests fror CGroupApi (#1539)

8863864

* Added unit tests fror CGroupApi * Remove comments

Addressing PR comments and cleanup

4d4d985

Merge branch 'cgroups' into vameru/cgroup-telemetry

b0bfd08

Fixing float issues for tests

11b5a75

Addressing latest round of comments

ee5dfbc

Adding more tests for Metric and CGroupTelemetry class

689fdbd

Adding more tests to check state changes and fixing locks for _tracked

a123635

Merge pull request #1538 from vrdmr/vameru/cgroup-telemetry

368c71e

Making cgroup telemetry work end to end, with new spec for metrics

Adding more unittests to enable cgroup telemetry tests

c6e2952

CGroupConfigurator unit tests (#1543)

6e2a02a

* Added unit tests for CGroupConfigurator * Added test for start_extension_command * Do not mount cgroups

Addressing PR comments - part 1

c4a3010

Merge branch 'cgroups' into vameru/cgroup-test-extension-with-cgroups…

296dc50

…-enabled

Fix the string decoding issue & added better test realistic cgroup case.

d397c66

Improve error handling in remove cgroups (#1545)

128f3c8

Fixing unittest runs issue and review comments.

070e15f

Removing reference to Travis

a2e84c4

nit fixes; add some test for message json

c3d0ab8

Changing the is_supported to enabled.

bea5923

nit; correcting decorator messages

71bf281

Merge pull request #1541 from vrdmr/vameru/cgroup-test-extension-with…

468714c

…-cgroups-enabled Adding more unittests to enable cgroup telemetry tests and fixing nit bugs in CGT class.

narrieta and others added 20 commits June 10, 2019 16:50

Create unique scopes for extensions

69022c6

Use _ as separator for scope name

f153b56

Code review feedback

8379bbb

Merge pull request #1549 from narrieta/unique-scope

37420aa

Create unique scopes for extensions

Prevent adding duplicates in _tracked data structure.

a780d28

Change the scope name to have the .scope suffix

0767eb9

Also, added a test for empty_cgroup.

nit fixes; correcting the systemd filename and other unittest fixes.

5d628b0

is_tracked check only with path now.

909de2c

Changed the implementation and the unittests for the is_tracked check.

Fix the test_monitor unittest

994eb17

Rebased on cgroups, and fixed unittests.

74bd5f7

Also scope name is now not created in this PR

Review comments addressed.

8194f84

Merge pull request #1548 from vrdmr/vameru/cgroups-bug-fixes

d12a03a

Bug fixes for duplicate copies and scope name

Merge remote-tracking branch 'upstream/cgroups' into cgroups

51471d4

Preventing incorrect metrics to be sent on telemetry

ee8a741

Exposed the cgroups.collect exceptions to distinguish difference between incorrect configuration and 0 value.

Fixing the unittests

52a5994

Review comments addressed

bb622b1

Addressing review comments; periodic logger expanded

113fc1b

Refactored periodic logger, and other review comments addressed

aae9fc9

Simplifying periodic_* interfaces

338adc0

Merge pull request #1553 from vrdmr/vameru/remove-empty-perf-metrics

ab9cffe

Preventing incorrect metrics to be sent on telemetry

vrdmr requested review from narrieta and pgombar June 14, 2019 00:55

pgombar approved these changes Jun 14, 2019

View reviewed changes

vrdmr merged commit 3816e53 into develop Jun 14, 2019

vrdmr deleted the cgroups branch June 14, 2019 18:11

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Merge CGroups into Develop #1555

Merge CGroups into Develop #1555

vrdmr commented Jun 14, 2019 •

edited

Loading

codecov bot commented Jun 14, 2019

codecov bot commented Jun 14, 2019 •

edited

Loading

pgombar left a comment

Merge CGroups into Develop #1555

Merge CGroups into Develop #1555

Conversation

vrdmr commented Jun 14, 2019 • edited Loading

Description

PR information

Quality of Code and Contribution Guidelines

codecov bot commented Jun 14, 2019

Codecov Report

codecov bot commented Jun 14, 2019 • edited Loading

Codecov Report

pgombar left a comment

Choose a reason for hiding this comment

vrdmr commented Jun 14, 2019 •

edited

Loading

codecov bot commented Jun 14, 2019 •

edited

Loading