Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix utf-encoding for reporting firewall-setup logs #2233

Merged
merged 5 commits into from
Apr 30, 2021

Conversation

larohra
Copy link
Contributor

@larohra larohra commented Apr 28, 2021

Description

Fix utf-encoding for reporting firewall-setup logs

Issue #


PR information

  • The title of the PR is clear and informative.
  • There are a small number of commits, each of which has an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
  • If applicable, the PR references the bug/issue that it fixes in the description.
  • New Unit tests were added for the changes made

Quality of Code and Contribution Guidelines

@codecov
Copy link

codecov bot commented Apr 28, 2021

Codecov Report

Merging #2233 (a965f66) into develop (5a97dec) will increase coverage by 0.00%.
The diff coverage is 66.66%.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #2233   +/-   ##
========================================
  Coverage    70.63%   70.63%           
========================================
  Files           96       96           
  Lines        13615    13616    +1     
  Branches      1928     1928           
========================================
+ Hits          9617     9618    +1     
  Misses        3583     3583           
  Partials       415      415           
Impacted Files Coverage Δ
azurelinuxagent/common/persist_firewall_rules.py 76.38% <66.66%> (+0.16%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5a97dec...a965f66. Read the comment docs.

narrieta
narrieta previously approved these changes Apr 28, 2021
@larohra larohra changed the base branch from develop to release-2.3.0.0 April 30, 2021 23:46
@larohra larohra changed the base branch from release-2.3.0.0 to develop April 30, 2021 23:49
@larohra larohra dismissed narrieta’s stale review April 30, 2021 23:49

The base branch was changed.

@larohra larohra requested a review from narrieta April 30, 2021 23:51
@larohra larohra merged commit c468d0a into Azure:develop Apr 30, 2021
@larohra larohra deleted the fix-firewall-utf branch April 30, 2021 23:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants