Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix utf logging for persist firewall rules - CP: #2233 #2237

Merged
merged 3 commits into from
May 4, 2021

Conversation

larohra
Copy link
Contributor

@larohra larohra commented May 3, 2021

Description

Fix utf logging for persist firewall rules
(Cherry-pick #2233 )

Issue #


PR information

  • The title of the PR is clear and informative.
  • There are a small number of commits, each of which has an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
  • If applicable, the PR references the bug/issue that it fixes in the description.
  • New Unit tests were added for the changes made

Quality of Code and Contribution Guidelines

@codecov
Copy link

codecov bot commented May 4, 2021

Codecov Report

Merging #2237 (3d6b2d0) into release-2.3.0.0 (2ab6ce4) will increase coverage by 0.02%.
The diff coverage is 66.66%.

Impacted file tree graph

@@                 Coverage Diff                 @@
##           release-2.3.0.0    #2237      +/-   ##
===================================================
+ Coverage            70.59%   70.62%   +0.02%     
===================================================
  Files                   96       96              
  Lines                13615    13616       +1     
  Branches              1928     1928              
===================================================
+ Hits                  9612     9616       +4     
+ Misses                3585     3584       -1     
+ Partials               418      416       -2     
Impacted Files Coverage Δ
azurelinuxagent/common/persist_firewall_rules.py 76.38% <66.66%> (+0.16%) ⬆️
azurelinuxagent/ga/collect_telemetry_events.py 91.43% <0.00%> (+1.02%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2ab6ce4...3d6b2d0. Read the comment docs.

@larohra larohra merged commit b8a006f into Azure:release-2.3.0.0 May 4, 2021
@larohra larohra deleted the fix-utf-log branch May 4, 2021 00:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants