Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change the attributes in generated cases #5150

Merged
merged 6 commits into from
Nov 12, 2024

Conversation

ArcturusZhang
Copy link
Member

@ArcturusZhang ArcturusZhang commented Nov 5, 2024

Fixes #5151

Description

change these ahead of time to reduce the amount of changes in the regen PR of this PR

Changes including:

  • Previously we write:
[NUnit.Framework.Test]
[NUnit.Framework.Ignore("...")]

because of the refactor, the above way is no longer valid, now the new way is:

using NUnit.Framework;

[Test]
[Ignore("...")]

sample collecting scripts are also modified to align with the new way to avoid those NUnit namespace to appear in sample codes.

  • the sentence in the Ignore attribute has been changed to align with whatever we have in DPG samples. This is not part of the sample, we added there so that the test will not be run on CI.
  • A new example is added to verify the cases with option bags in mgmt plane.
  • Some strings in the sample is always written in formattable string style, now they are changed to be literal strings.
  • The comment before each sample method has been removed.

Checklist

To ensure a quick review and merge, please ensure:

  • The PR has a understandable title and description explaining the why and what.
  • The PR is opened in draft if not ready for review yet.
    • If opened in draft, please allocate sufficient time (24 hours) after moving out of draft for review
  • The branch is recent enough to not have merge conflicts upon creation.

Ready to Land?

  • Build is completely green
    • Submissions with test failures require tracking issue and approval of a CODEOWNER
  • At least one +1 review by a CODEOWNER
  • All -1 reviews are confirmed resolved by the reviewer
    • Override/Marking reviews stale must be discussed with CODEOWNERS first

@ArcturusZhang ArcturusZhang merged commit 1849c38 into Azure:main Nov 12, 2024
8 checks passed
@ArcturusZhang ArcturusZhang deleted the change-test-attributes branch November 12, 2024 02:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants