Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates to dotnet example automation for recent changes on dotnet side #9359

Merged
merged 5 commits into from
Nov 11, 2024

Conversation

ArcturusZhang
Copy link
Member

@ArcturusZhang ArcturusZhang commented Nov 11, 2024

In azure-sdk-for-net, we are changing how the namespace works.
Previously, to avoid NUnit related namespaces to be added into the using statements, we write code in this way:

[NUnit.Framework.Test]
public async Task Sample_DoSomething() {}

Because of a refactor of code in dotnet generator, the above way is no longer possible to write - therefore the new code looks like this:

using NUnit.Framework;

[Test]
public async Task Sample_DoSomething() {}

Therefore this PR is changing how we collect those namespaces in usings to exclude those NUnit namespaces.

Unit test cases are also updated.

Related .Net generator changes here:

@ArcturusZhang ArcturusZhang requested a review from a team as a code owner November 11, 2024 03:01
@ArcturusZhang ArcturusZhang reopened this Nov 11, 2024
@ArcturusZhang ArcturusZhang merged commit 607a9d8 into Azure:main Nov 11, 2024
9 checks passed
@ArcturusZhang ArcturusZhang deleted the add-ignore-list-for-using branch November 11, 2024 05:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants