-
Notifications
You must be signed in to change notification settings - Fork 207
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove the code for picking services #3611
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is also this code in: environment_service_create.go
azure-dev/cli/azd/internal/vsrpc/environment_service_create.go
Lines 116 to 126 in 733bfdc
var servicesToExpose = make([]string, 0) | |
for _, svc := range newEnv.Services { | |
if svc.IsExternal { | |
servicesToExpose = append(servicesToExpose, svc.Name) | |
} | |
} | |
if err := azdEnv.Config.Set("services.app.config.exposedServices", servicesToExpose); err != nil { | |
return false, fmt.Errorf("setting exposed services: %w", err) | |
} |
We should be able to remove this now as well.
Otherwise, LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@davidfowl @mitchdenny FYI, we are removing the external services handling from Azd and its integration with VS Publish flow. VS has already removed it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
dotnet/aspire#3278 for Preview-5 has breaking changes. Consume those changes and test too.
containerPort
->targetPort
- http/https bindings have
external
property
@rajeshkamal5050 , the breaking changes are covered here: #3612 |
Azure Dev CLI Install InstructionsInstall scriptsMacOS/Linux
bash:
pwsh:
WindowsPowerShell install
MSI install
Standalone Binary
MSIDocumentationlearn.microsoft.com documentationtitle: Azure Developer CLI reference
|
fix: #3608
fix: #3280
fix: #3284