-
Notifications
You must be signed in to change notification settings - Fork 207
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
additional ports support #3612
additional ports support #3612
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks good. Just brought up some questions if we want to simplify buildAcaIngress
-- it's 80+ lines long, and I did find it a little hard to parse through.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I do think that this is pretty close (and the detailed tests give me a better understanding of what's going on and confidence this is right, which is great!) - but I will admit that I have sort of forgotten the algorithm that we discussed with David and his C# code sample, so I can't say for sure that I understand exactly what's going on here and can confirm it was correct. I made a few comments about the actual merging of values with things that stuck out or confused me, but I feel like this sort of thing is the place where a few helpful comments as we go along about what we are doing (and what invariants we've established) might be helpful.
After testing this, we need to relax some of the rules around how we pick the http ingress. If there are multiple HTTP internal endpoints, the first one becomes the ingress and the rest are additional ports. |
I made that change here dotnet/aspire@9077747 |
From our meeting, instead of throwing because of the 5 endpoint limitation, we warn but let the deployment go through. This means we don't need to update azd if a customer gets that restriction relaxed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the improvements to the readability of the core binding algorithm. Overall looks good - but let's adopt something like what I outlined to track the order of the keys instead of a global written to by UnmarshalText. Once that's done, I think this will be good!
Azure Dev CLI Install InstructionsInstall scriptsMacOS/Linux
bash:
pwsh:
WindowsPowerShell install
MSI install
Standalone Binary
MSIDocumentationlearn.microsoft.com documentationtitle: Azure Developer CLI reference
|
fix: #3267