Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing WEBSITE_CONTAINER_READY=0 env variable check for DotnetIsolatedLinuxPlaceholder profile #2629

Merged
merged 1 commit into from
Jul 29, 2024

Conversation

kshyju
Copy link
Member

@kshyju kshyju commented Jul 29, 2024

In this PR, we added a profile condition to check if the environment variable WEBSITE_CONTAINER_READY is set to 0, following our wiki page. However, testing revealed this does not work, as the flex SKU did not set this environment variable. The Linux team conducted an initial investigation to find the impact of adding this environment variable to the container but found that other parts of the system expect this value to be not null rather than checking for a specific value (1). We have decided to remove this environment variable check, understanding the impact of this change.

Pull request checklist

  • My changes do not require documentation changes
    • Otherwise: Documentation issue linked to PR
  • My changes should not be added to the release notes for the next release
    • Otherwise: I've added my notes to release_notes.md
  • My changes do not need to be backported to a previous version
    • Otherwise: Backport tracked by issue/PR #issue_or_pr
  • I have added all required tests (Unit tests, E2E tests)

…tedLinuxPlaceholder profile.

Bumped version to 1.0.10
@kshyju kshyju requested a review from pragnagopa July 29, 2024 21:15
@kshyju kshyju merged commit 5b1dbdb into main Jul 29, 2024
15 checks passed
@kshyju kshyju deleted the shkr/fnh_remove_linux_container_ready branch July 29, 2024 22:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants