Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TypeSpec Validation] Rule NpmPrefix fails on Windows with lower-case drive letter #26557

Closed
mikeharder opened this issue Nov 3, 2023 · 0 comments · Fixed by #27002
Closed

[TypeSpec Validation] Rule NpmPrefix fails on Windows with lower-case drive letter #26557

mikeharder opened this issue Nov 3, 2023 · 0 comments · Fixed by #27002
Assignees
@mikeharder
Labels
Spec PR Tools Tooling that runs in azure-rest-api-specs repo.

Comments

@mikeharder
Copy link
Member

mikeharder commented Nov 3, 2023 •
edited
Loading 

C:\>cd /d c:\git\specs

c:\git\specs>npm ci

c:\git\specs>npx tsv specification\contosowidgetmanager\Contoso.WidgetManager
Running TypeSpecValidation on folder: specification/contosowidgetmanager/Contoso.WidgetManager

Executing rule: NpmPrefix
run command:npm prefix
Expected npm prefix: C:\git\specs
Actual npm prefix: c:\git\specs
Rule NpmPrefix failed

We will probably need/want to do case-insensitive path compare on Windows, since Node APIs are inconsitent:

nodejs/node#6624
@mikeharder mikeharder added the Spec PR Tools Tooling that runs in azure-rest-api-specs repo. label Nov 3, 2023
@mikeharder mikeharder moved this from 🤔 Triage to 🐝 Dev in Azure SDK EngSys 🚢🎉 Dec 6, 2023
@ckairen ckairen mentioned this issue Dec 8, 2023
Merged
@mikeharder mikeharder assigned mikeharder and unassigned ckairen Dec 14, 2023
@mikeharder mikeharder moved this from 🐝 Dev to 🔬 Dev in PR in Azure SDK EngSys 🚢🎉 Dec 14, 2023
mikeharder pushed a commit that referenced this issue Dec 14, 2023
@ckairen
[TypeSpecValidation] bug fix: drive letter inconsistency for windows (#…
80aaac5 
…27002)

- Fixes #26557
@github-project-automation github-project-automation bot moved this from 🔬 Dev in PR to 🎊 Closed in Azure SDK EngSys 🚢🎉 Dec 14, 2023
@github-project-automation github-project-automation bot moved this to 🎊 Closed in Spec PR Tools Dec 14, 2023
arifibrahim4 pushed a commit that referenced this issue Feb 26, 2024
@ckairen @arifibrahim4
[TypeSpecValidation] bug fix: drive letter inconsistency for windows (#…
8c0a0df 
…27002)

- Fixes #26557
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mikeharder mikeharder

Labels
Spec PR Tools Tooling that runs in azure-rest-api-specs repo.
Projects
Azure SDK EngSys 🚢🎉
Archived in project
Spec PR Tools
Status: 🎊 Closed
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[TypeSpecValidation] bug fix: drive letter inconsistency for windows ckairen/azure-rest-api-specs
2 participants
@mikeharder @ckairen