[TypeSpecValidation] bug fix: drive letter inconsistency for windows #27002
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ckairen
added
the
Central-EngSys
Next Steps to Merge✔️ All automated merging requirements have been met! Refer to step 4 in the PR workflow diagram (even if your PR is for data plane, not ARM). |
Swagger Validation Report
|
Swagger Generation Artifacts
|
|
PR validation pipeline restarted successfully. If there is ApiView generated, it will be updated in this comment. |
|
/azp run |
|
Azure Pipelines successfully started running 4 pipeline(s). |
ckairen
requested review from
weshaggard,
mikeharder and
konrad-jamrozik
as code owners
|
/azp run |
|
Azure Pipelines successfully started running 4 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 4 pipeline(s). |
mikeharder
requested changes
Dec 8, 2023
| .resolve(folder) | ||
| .split(path.sep) | ||
| .join("/") | ||
| .replace(/[a-zA-Z]:/g, ""); |
There was a problem hiding this comment.
You are just removing the drive letter? This is unsound, since C:\ is not equivalent to D:\. I think a better option would be to keep the drive letter but normalize to upper-case (which is usually how drive letters are represented).
There was a problem hiding this comment.
Do we even care about the drive letter? Should we just strip and make everything relative to the repo root?
There was a problem hiding this comment.
This is a general-purpose helper function. Really, all we need to do is normalize the drive letter casing, and it should be good.
mikeharder
approved these changes
Dec 14, 2023
|
/azp run TypeSpec Validation - CI |
|
No pipelines are associated with this pull request. |
|
/azp run TypeSpec Validation - CI |
|
Azure Pipelines successfully started running 1 pipeline(s). |
arifibrahim4
pushed a commit
that referenced
this pull request
Feb 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #26557