Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Hub Generated] Review request for Microsoft.StorageCache to add version stable/2020-10-01 #11407

Merged
merged 18 commits into from
Dec 25, 2020
Merged

[Hub Generated] Review request for Microsoft.StorageCache to add version stable/2020-10-01 #11407

merged 18 commits into from
Dec 25, 2020

Conversation

brpanask
Copy link
Contributor

@brpanask brpanask commented Oct 27, 2020 •
edited
Loading

This is a PR generated at OpenAPI Hub. You can view your work branch via this link.

Contribution checklist:

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

  • Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.

    • Adding new API(s)
    • Adding a new API version
    • Adding a new service

  • If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If there are following updates in the PR, ensure to request an approval from API Review Board as defined in the Breaking Change Policy.

  • Removing API(s) in stable version
  • Removing properties in stable version
  • Removing API version(s) in stable version
  • Updating API in stable version with Breaking Change Validation errors
  • Updating API(s) in preview over 1 year

Please follow the link to find more details on PR review process.

@openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Oct 27, 2020 •
edited
Loading

Swagger Validation Report

️️✔️BreakingChange succeeded [Detail] [Expand] 
There are no breaking changes.
️⚠️LintDiff: 7 Warnings warning [Detail]

Rule Message
⚠️ R3018 - EnumInsteadOfBoolean Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: extendedGroupsEnabled
New: Microsoft.StorageCache/stable/2020-10-01/storagecache.json#L1571
⚠️ R3018 - EnumInsteadOfBoolean Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: encryptLdapConnection
New: Microsoft.StorageCache/stable/2020-10-01/storagecache.json#L1606
⚠️ R3018 - EnumInsteadOfBoolean Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: requireValidCertificate
New: Microsoft.StorageCache/stable/2020-10-01/storagecache.json#L1610
⚠️ R3018 - EnumInsteadOfBoolean Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: autoDownloadCertificate
New: Microsoft.StorageCache/stable/2020-10-01/storagecache.json#L1614
⚠️ R3018 - EnumInsteadOfBoolean Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: suid
New: Microsoft.StorageCache/stable/2020-10-01/storagecache.json#L1705
⚠️ R3018 - EnumInsteadOfBoolean Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: submountAccess
New: Microsoft.StorageCache/stable/2020-10-01/storagecache.json#L1709
⚠️ R3018 - EnumInsteadOfBoolean Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: rootSquash
New: Microsoft.StorageCache/stable/2020-10-01/storagecache.json#L1713
️️✔️Avocado succeeded [Detail] [Expand] 
Validation passes for Avocado.
️️✔️ModelValidation succeeded [Detail] [Expand] 
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand] 
Validation passes for SemanticValidation.
️⚠️[Staging] Cross Version BreakingChange (Base on preview version): 47 Warnings warning [Detail] Only 10 items are listed, please refer to log for more details.

Rule Message
⚠️ 1008 - ModifiedOperationId The operation id has been changed from 'Caches_Create' to 'Caches_CreateOrUpdate'. This will impact generated code.
New: Microsoft.StorageCache/stable/2020-10-01/storagecache.json#L417:7
Old: Microsoft.StorageCache/preview/2019-08-01-preview/storagecache.json#L364:7
⚠️ 1008 - ModifiedOperationId The operation id has been changed from 'StorageTargets_Create' to 'StorageTargets_CreateOrUpdate'. This will impact generated code.
New: Microsoft.StorageCache/stable/2020-10-01/storagecache.json#L998:7
Old: Microsoft.StorageCache/preview/2019-08-01-preview/storagecache.json#L854:7
⚠️ 1011 - AddingResponseCode The new version adds a response code '202'.
New: Microsoft.StorageCache/stable/2020-10-01/storagecache.json#L468:11
⚠️ 1011 - AddingResponseCode The new version adds a response code '204'.
New: Microsoft.StorageCache/stable/2020-10-01/storagecache.json#L658:11
⚠️ 1011 - AddingResponseCode The new version adds a response code '204'.
New: Microsoft.StorageCache/stable/2020-10-01/storagecache.json#L722:11
⚠️ 1011 - AddingResponseCode The new version adds a response code '204'.
New: Microsoft.StorageCache/stable/2020-10-01/storagecache.json#L786:11
⚠️ 1011 - AddingResponseCode The new version adds a response code '202'.
New: Microsoft.StorageCache/stable/2020-10-01/storagecache.json#L1057:11
⚠️ 1011 - AddingResponseCode The new version adds a response code '204'.
New: Microsoft.StorageCache/stable/2020-10-01/storagecache.json#L1120:11
⚠️ 1026 - TypeChanged The new version has a different type '' than the previous one 'object'.
New: Microsoft.StorageCache/stable/2020-10-01/storagecache.json#L1939:9
Old: Microsoft.StorageCache/preview/2019-08-01-preview/storagecache.json#L1550:13
⚠️ 1026 - TypeChanged The new version has a different type '' than the previous one 'object'.
New: Microsoft.StorageCache/stable/2020-10-01/storagecache.json#L1943:9
Old: Microsoft.StorageCache/preview/2019-08-01-preview/storagecache.json#L1554:13
️⚠️[Staging] Cross Version BreakingChange (Base on stable version): 1 Warnings warning [Detail]

Rule Message
⚠️ 1033 - RemovedProperty The new version is missing a property found in the old version. Was 'rootSquash' renamed or removed?
New: Microsoft.StorageCache/stable/2020-10-01/storagecache.json#L1478:7
Old: Microsoft.StorageCache/stable/2020-03-01/storagecache.json#L1410:7
️️✔️CredScan succeeded [Detail] [Expand] 
There is no credential detected.
Posted by Swagger Pipeline | How to fix these errors?

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Oct 27, 2020 •
edited
Loading

Azure CLI Extension Generation

  • Installation instruction for service storagecache [Preview Changes]
    curl -L "https://portal.azure-devex-tools.com/api/sdk-dl-pub?p=Azure/azure-rest-api-specs/11407/azure-cli-extensions/storagecache/storagecache-0.1.0-py3-none-any.whl" -o storagecache-0.1.0-py3-none-any.whl
az extension add --source=storagecache-0.1.0-py3-none-any.whl
️✔️ succeeded [Logs] [Expand Details]
  • ️✔️ Generate from 2f688fe with merge commit 3040a5940ae27f1f0675907e213d7b18bc57da8a. Azure CLI Automation 13.0.17.20200918.2 
    [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'ApiOperation-display' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
[AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'CacheIdentity' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
[AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'CacheNetworkSettings' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
[AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'CacheEncryptionSettings' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
[AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'CacheSecuritySettings' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
[AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'CacheActiveDirectorySettings-credentials' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
[AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'CacheUsernameDownloadSettings-credentials' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
[AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'NfsAccessPolicy' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
[AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'NfsAccessRule' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
[AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'KeyVaultKeyReference' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
[AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'KeyVaultKeyReference-sourceVault' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
[AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'CacheHealth' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
[AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'StorageTargetResource' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
[AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'Nfs3Target' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
[AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'ClfsTarget' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
[AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'UnknownTarget' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
[AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'Restriction' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
[AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'ResourceSkusResult' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
[AutoRest] WARNING (PreCheck/CheckDuplicateSchemas): Checking for duplicate schemas, this could take a (long) while.  Run with --verbose for more detail.
[AutoRest] WARNING (): Operation Update has already existed in group! Skip split!
[AutoRest] WARNING (): cli.auto-parameter-hidden is not true, skip visibility cleaner
[AutoRest] 
[AutoRest] NO TEST SCENARIO PROVIDED - DEFAULT WILL BE USED
[AutoRest] ADD FOLLOWING SECTION TO readme.cli.md FILE TO MODIFY IT
[AutoRest] --------------------------------------------------------
[AutoRest]   test-scenario:
[AutoRest]     - name: /AscOperations/get/AscOperations_Get
[AutoRest]     - name: /Caches/put/Caches_CreateOrUpdate
[AutoRest]     - name: /Caches/put/Caches_CreateOrUpdate_ldap_only
[AutoRest]     - name: /Caches/get/Caches_Get
[AutoRest]     - name: /Caches/get/Caches_List
[AutoRest]     - name: /Caches/get/Caches_ListByResourceGroup
[AutoRest]     - name: /Caches/patch/Caches_Update
[AutoRest]     - name: /Caches/patch/Caches_Update_ldap_only
[AutoRest]     - name: /Caches/post/Caches_Flush
[AutoRest]     - name: /Caches/post/Caches_Start
[AutoRest]     - name: /Caches/post/Caches_Stop
[AutoRest]     - name: /Caches/post/Caches_UpgradeFirmware
[AutoRest]     - name: /Caches/delete/Caches_Delete
[AutoRest]     - name: /Skus/get/Skus_List
[AutoRest]     - name: /StorageTargets/put/StorageTargets_CreateOrUpdate
[AutoRest]     - name: /StorageTargets/put/StorageTargets_CreateOrUpdate_NoJunctions
[AutoRest]     - name: /StorageTargets/get/StorageTargets_Get
[AutoRest]     - name: /StorageTargets/get/StorageTargets_List
[AutoRest]     - name: /StorageTargets/delete/StorageTargets_Delete
[AutoRest]     - name: /UsageModels/get/UsageModels_List
[AutoRest] --------------------------------------------------------
  • ️✔️storagecache [View full logs]  [Preview Azure CLI Changes]

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Oct 27, 2020 •
edited
Loading

azure-sdk-for-go

❌ failed [Logs] [Expand Details]
  • ❌ Generate from 2f688fe with merge commit 3040a5940ae27f1f0675907e213d7b18bc57da8a. SDK Automation 13.0.17.20200918.2 
    [AutoRest] Failure during batch task - {"tag":"package-2020-10-01"} -- Error: [Exception] No input files provided.
[AutoRest] 
[AutoRest] Use --help to get help information..
Failed to run autorest.
Error: /z/node_modules/.bin/autorest --use=@microsoft.azure/autorest.go@~2.1.157 --go --verbose --multiapi --use-onever --preview-chk --version=V2 --go-sdk-folder=/z/work/src/github.com/Azure/azure-sdk-for-go /z/work/azure-rest-api-specs/specification/storagecache/resource-manager/readme.md Failure during batch task - {"tag":"package-2020-10-01"} -- Error: [Exception] No input files provided.

    Use --help to get help information..
    
, {}
    
Failed to find any diff after autorest so no changed packages was found.

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Oct 27, 2020 •
edited
Loading

azure-sdk-for-net

⚠️ warning [Logs] [Expand Details]
  • ⚠️ Generate from 2f688fe with merge commit 3040a5940ae27f1f0675907e213d7b18bc57da8a. SDK Automation 13.0.17.20200918.2 
    [AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied
Failed to find any diff after autorest so no changed packages was found.

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Oct 27, 2020 •
edited
Loading

azure-sdk-for-js

️✔️ succeeded [Logs] [Expand Details]
  • ️✔️ Generate from 2f688fe with merge commit 3040a5940ae27f1f0675907e213d7b18bc57da8a. SDK Automation 13.0.17.20200918.2
  • ️✔️@azure/arm-storagecache [View full logs]  [Preview SDK Changes]
    Only show 100 items here, please refer to log for details.
    [npmPack] npm WARN deprecated rollup-plugin-node-resolve@5.2.0: This package has been deprecated and is no longer maintained. Please use @rollup/plugin-node-resolve.
[npmPack] npm WARN deprecated resolve-url@0.2.1: https://github.com/lydell/resolve-url#deprecated
[npmPack] npm WARN deprecated urix@0.1.0: Please see https://github.com/lydell/urix#deprecated
[npmPack] npm notice created a lockfile as package-lock.json. You should commit this file.
[npmPack] loaded rollup.config.js with warnings
[npmPack] (!) Unused external imports
[npmPack] default imported from external module 'rollup' but never used
[npmPack] 
[npmPack] ./esm/storageCacheManagementClient.js → ./dist/arm-storagecache.js...
[npmPack] created ./dist/arm-storagecache.js in 319ms
[npmPack] npm notice 
[npmPack] npm notice package: @azure/arm-storagecache@2.0.0
[npmPack] npm notice === Tarball Contents === 
[npmPack] npm notice 103.7kB dist/arm-storagecache.js                        
[npmPack] npm notice 34.3kB  dist/arm-storagecache.min.js                    
[npmPack] npm notice 1.8kB   esm/operations/ascOperations.js                 
[npmPack] npm notice 355B    esm/models/ascOperationsMappers.js              
[npmPack] npm notice 17.9kB  esm/operations/caches.js                        
[npmPack] npm notice 849B    esm/models/cachesMappers.js                     
[npmPack] npm notice 263B    esm/models/index.js                             
[npmPack] npm notice 444B    esm/operations/index.js                         
[npmPack] npm notice 42.3kB  esm/models/mappers.js                           
[npmPack] npm notice 2.2kB   esm/operations/operations.js                    
[npmPack] npm notice 464B    esm/models/operationsMappers.js                 
[npmPack] npm notice 2.3kB   esm/models/parameters.js                        
[npmPack] npm notice 916B    rollup.config.js                                
[npmPack] npm notice 2.3kB   esm/operations/skus.js                          
[npmPack] npm notice 413B    esm/models/skusMappers.js                       
[npmPack] npm notice 1.9kB   esm/storageCacheManagementClient.js             
[npmPack] npm notice 2.6kB   esm/storageCacheManagementClientContext.js      
[npmPack] npm notice 9.7kB   esm/operations/storageTargets.js                
[npmPack] npm notice 861B    esm/models/storageTargetsMappers.js             
[npmPack] npm notice 2.3kB   esm/operations/usageModels.js                   
[npmPack] npm notice 374B    esm/models/usageModelsMappers.js                
[npmPack] npm notice 1.7kB   package.json                                    
[npmPack] npm notice 457B    tsconfig.json                                   
[npmPack] npm notice 198.1kB dist/arm-storagecache.js.map                    
[npmPack] npm notice 30.0kB  dist/arm-storagecache.min.js.map                
[npmPack] npm notice 791B    esm/operations/ascOperations.d.ts.map           
[npmPack] npm notice 1.0kB   esm/operations/ascOperations.js.map             
[npmPack] npm notice 205B    esm/models/ascOperationsMappers.d.ts.map        
[npmPack] npm notice 218B    esm/models/ascOperationsMappers.js.map          
[npmPack] npm notice 4.4kB   esm/operations/caches.d.ts.map                  
[npmPack] npm notice 8.9kB   esm/operations/caches.js.map                    
[npmPack] npm notice 473B    esm/models/cachesMappers.d.ts.map               
[npmPack] npm notice 486B    esm/models/cachesMappers.js.map                 
[npmPack] npm notice 14.3kB  esm/models/index.d.ts.map                       
[npmPack] npm notice 246B    esm/operations/index.d.ts.map                   
[npmPack] npm notice 126B    esm/models/index.js.map                         
[npmPack] npm notice 260B    esm/operations/index.js.map                     
[npmPack] npm notice 2.3kB   esm/models/mappers.d.ts.map                     
[npmPack] npm notice 23.5kB  esm/models/mappers.js.map                       
[npmPack] npm notice 1.0kB   esm/operations/operations.d.ts.map              
[npmPack] npm notice 1.4kB   esm/operations/operations.js.map                
[npmPack] npm notice 251B    esm/models/operationsMappers.d.ts.map           
[npmPack] npm notice 264B    esm/models/operationsMappers.js.map             
[npmPack] npm notice 588B    esm/models/parameters.d.ts.map                  
[npmPack] npm notice 1.7kB   esm/models/parameters.js.map                    
[npmPack] npm notice 1.0kB   esm/operations/skus.d.ts.map                    
[npmPack] npm notice 1.5kB   esm/operations/skus.js.map                      
[npmPack] npm notice 226B    esm/models/skusMappers.d.ts.map                 
[npmPack] npm notice 239B    esm/models/skusMappers.js.map                   
[npmPack] npm notice 811B    esm/storageCacheManagementClient.d.ts.map       
[npmPack] npm notice 1.0kB   esm/storageCacheManagementClient.js.map         
[npmPack] npm notice 523B    esm/storageCacheManagementClientContext.d.ts.map
[npmPack] npm notice 1.4kB   esm/storageCacheManagementClientContext.js.map  
[npmPack] npm notice 2.4kB   esm/operations/storageTargets.d.ts.map          
[npmPack] npm notice 4.2kB   esm/operations/storageTargets.js.map            
[npmPack] npm notice 489B    esm/models/storageTargetsMappers.d.ts.map       
[npmPack] npm notice 502B    esm/models/storageTargetsMappers.js.map         
[npmPack] npm notice 1.0kB   esm/operations/usageModels.d.ts.map             
[npmPack] npm notice 1.5kB   esm/operations/usageModels.js.map               
[npmPack] npm notice 217B    esm/models/usageModelsMappers.d.ts.map          
[npmPack] npm notice 230B    esm/models/usageModelsMappers.js.map            
[npmPack] npm notice 3.2kB   README.md                                       
[npmPack] npm notice 1.8kB   esm/operations/ascOperations.d.ts               
[npmPack] npm notice 3.2kB   src/operations/ascOperations.ts                 
[npmPack] npm notice 127B    esm/models/ascOperationsMappers.d.ts            
[npmPack] npm notice 314B    src/models/ascOperationsMappers.ts              
[npmPack] npm notice 12.9kB  esm/operations/caches.d.ts                      
[npmPack] npm notice 24.2kB  src/operations/caches.ts                        
[npmPack] npm notice 621B    esm/models/cachesMappers.d.ts                   
[npmPack] npm notice 863B    src/models/cachesMappers.ts                     
[npmPack] npm notice 40.1kB  esm/models/index.d.ts                           
[npmPack] npm notice 213B    esm/operations/index.d.ts                       
[npmPack] npm notice 38.2kB  src/models/index.ts                             
[npmPack] npm notice 412B    src/operations/index.ts                         
[npmPack] npm notice 3.0kB   esm/models/mappers.d.ts                         
[npmPack] npm notice 33.3kB  src/models/mappers.ts                           
[npmPack] npm notice 2.1kB   esm/operations/operations.d.ts                  
[npmPack] npm notice 4.2kB   src/operations/operations.ts                    
[npmPack] npm notice 236B    esm/models/operationsMappers.d.ts               
[npmPack] npm notice 434B    src/models/operationsMappers.ts                 
[npmPack] npm notice 673B    esm/models/parameters.d.ts                      
[npmPack] npm notice 2.3kB   src/models/parameters.ts                        
[npmPack] npm notice 2.1kB   esm/operations/skus.d.ts                        
[npmPack] npm notice 4.2kB   src/operations/skus.ts                          
[npmPack] npm notice 185B    esm/models/skusMappers.d.ts                     
[npmPack] npm notice 387B    src/models/skusMappers.ts                       
[npmPack] npm notice 1.4kB   esm/storageCacheManagementClient.d.ts

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Oct 27, 2020 •
edited
Loading

azure-sdk-for-java

❌ failed [Logs] [Expand Details]
  • ❌ Generate from 2f688fe with merge commit 3040a5940ae27f1f0675907e213d7b18bc57da8a. SDK Automation 13.0.17.20200918.2 
    [AutoRest] Failure during batch task - {"tag":"package-2020-10-01"} -- Error: [Exception] No input files provided.
[AutoRest] 
[AutoRest] Use --help to get help information..
Failed to run autorest.
Error: /z/node_modules/.bin/autorest --version=V2 --java --verbose --multiapi --use=@microsoft.azure/autorest.java@preview --azure-libraries-for-java-folder=/z/work/azure-sdk-for-java /z/work/azure-rest-api-specs/specification/storagecache/resource-manager/readme.md Failure during batch task - {"tag":"package-2020-10-01"} -- Error: [Exception] No input files provided.

    Use --help to get help information..
    
, {}
    
Failed to find any diff after autorest so no changed packages was found.

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Oct 27, 2020 •
edited
Loading

azure-sdk-for-python

- Breaking Change detected in SDK

⚠️ warning [Logs] [Expand Details]
  • ⚠️ Generate from 2f688fe with merge commit 3040a5940ae27f1f0675907e213d7b18bc57da8a. SDK Automation 13.0.17.20200918.2
  • ⚠️azure-mgmt-storagecache [View full logs]  [Preview SDK Changes] Breaking Change Detected
    [build_conf] INFO:packaging_tools:Building template azure-mgmt-storagecache
[build_conf] INFO:packaging_tools.conf:Skipping default conf since the file exists
[build_conf] INFO:packaging_tools:Skipping CHANGELOG.md template, since a previous one was found
[build_conf] INFO:packaging_tools:Template done azure-mgmt-storagecache
[build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
[build_package]   warnings.warn(msg)
[build_package] warning: no files found matching '*.py' under directory 'tests'
[build_package] warning: no files found matching '*.yaml' under directory 'tests'
[build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
[build_package]   warnings.warn(msg)
[build_package] warning: no files found matching '*.py' under directory 'tests'
[build_package] warning: no files found matching '*.yaml' under directory 'tests'
[breaking_change_setup] Ignoring mock: markers 'python_version <= "2.7"' don't match your environment
[ChangeLog] Size of delta 43.734% size of original (original: 26151 chars, delta: 11437 chars)
[ChangeLog] **Features**
[ChangeLog] 
[ChangeLog]   - Model StorageTarget has a new parameter location
[ChangeLog]   - Model StorageTarget has a new parameter system_data
[ChangeLog]   - Model Cache has a new parameter directory_services_settings
[ChangeLog]   - Model Cache has a new parameter system_data
[ChangeLog]   - Model StorageTargetResource has a new parameter location
[ChangeLog]   - Model StorageTargetResource has a new parameter system_data
[ChangeLog]   - Model ApiOperationDisplay has a new parameter description
[ChangeLog]   - Model ApiOperation has a new parameter origin
[ChangeLog]   - Model ApiOperation has a new parameter is_data_action
[ChangeLog]   - Model ApiOperation has a new parameter service_specification
[ChangeLog]   - Model NamespaceJunction has a new parameter nfs_access_policy
[ChangeLog]   - Added operation group AscOperations
[ChangeLog] 
[ChangeLog] **Breaking changes**
[ChangeLog] 
[ChangeLog]   - Parameter target_type of model StorageTarget is now required
[ChangeLog]   - Model CacheSecuritySettings has a new signature

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Oct 27, 2020 •
edited
Loading

azure-sdk-for-python-track2

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Oct 27, 2020 •
edited
Loading

azure-resource-manager-schemas

️✔️ succeeded [Logs] [Expand Details]
  • ️✔️ Generate from 2f688fe with merge commit 3040a5940ae27f1f0675907e213d7b18bc57da8a. Schema Automation 13.0.17.20200918.2 
    [storagecache][after_scripts|node] configure: WARNING: secure clearing/zeroing of memory is not supported by the selected crypto backend
[storagecache][after_scripts|node] configure: WARNING: secure clearing/zeroing of memory is not supported by the selected crypto backend
[storagecache][after_scripts|node] configure: WARNING: secure clearing/zeroing of memory is not supported by the selected crypto backend
  • ️✔️storagecache [View full logs]  [Preview Schema Changes] 
      [after_scripts|node] PostProcessor finished successfully.
[after_scripts|node]   5826 passing (1m)
AzureResourceSchema has no registered package commands.

    @openapi-sdkautomation
    Copy link

    openapi-sdkautomation bot commented Oct 27, 2020 •
    edited
    Loading

    Trenton Generation

    No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

    This was referenced Oct 27, 2020
    Open
    Open
    Open
    This was referenced Oct 27, 2020
    Open
    Open
    Open
    @brpanask brpanask marked this pull request as ready for review October 27, 2020 20:18
    @azure-pipelines
    Copy link

    Azure Pipelines successfully started running 1 pipeline(s).

    2 similar comments
    @azure-pipelines
    Copy link

    Azure Pipelines successfully started running 1 pipeline(s).

    @azure-pipelines
    Copy link

    Azure Pipelines successfully started running 1 pipeline(s).

    @brpanask brpanask added the DoNotMerge <valid label in PR review process> use to hold merge after approval label Oct 28, 2020
    @openapi-workflow-bot openapi-workflow-bot bot added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Oct 28, 2020
    @openapi-workflow-bot
    Copy link

    Hi, @brpanask your PR are labelled with WaitForARMFeedback. A notification email will be sent out shortly afterwards to notify ARM review board(armapireview@microsoft.com). cc @jianyexi

    @openapi-workflow-bot
    Copy link

    Hi, @brpanask Thanks for your PR. I am workflow bot for review process. Here are some small tips.

  • Please ensure to do self-check against checklists in first PR comment.
  • PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.
  • If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

    • Any feedback about review process or workflow bot, pls contact swagger and tools team. vsswagger@microsoft.com

    @azure-pipelines
    Copy link

    Azure Pipelines successfully started running 1 pipeline(s).

    @ArcturusZhang
    Copy link
    Member

    /azp run

    @azure-pipelines
    Copy link

    Azure Pipelines successfully started running 2 pipeline(s).

    @jianyexi
    Copy link
    Contributor

    @brpanask Could you fix the 'CredScan' error ?

    @brpanask
    Copy link
    Contributor Author

    @brpanask Could you fix the 'CredScan' error ?

    Not sure why a password example with a fake password is a problem. It wasn't returned in the responses.
    I saw some other specs with *******, so I put that in instead.

    Not sure if how the extra reviewer was added. I didn't add anyone unless changing that example auto added the reviewer.

    I should be ready to remove the DoNotMerge flag around Friday or Monday this week. 12/18, 12/21.

    @brpanask
    Copy link
    Contributor Author

    @brpanask Could you fix the 'CredScan' error ?

    Not sure why a password example with a fake password is a problem. It wasn't returned in the responses.
    I saw some other specs with *******, so I put that in instead.

    Not sure if how the extra reviewer was added. I didn't add anyone unless changing that example auto added the reviewer.

    I should be ready to remove the DoNotMerge flag around Friday or Monday this week. 12/18, 12/21.

    @jianyexi
    I changed it to * that I saw in other files. That didn't help either.
    Any suggestions or pointers to documentation about this.
    The field can be removed but its required for ldap usage which is the point of the example.

    "bindPassword": "ldapPassword123"
    "bindPassword": "********"

    @jianyexi
    Copy link
    Contributor

    @brpanask Could you fix the 'CredScan' error ?

    Not sure why a password example with a fake password is a problem. It wasn't returned in the responses.
    I saw some other specs with *******, so I put that in instead.
    Not sure if how the extra reviewer was added. I didn't add anyone unless changing that example auto added the reviewer.
    I should be ready to remove the DoNotMerge flag around Friday or Monday this week. 12/18, 12/21.

    @jianyexi
    I changed it to * that I saw in other files. That didn't help either.
    Any suggestions or pointers to documentation about this.
    The field can be removed but its required for ldap usage which is the point of the example.

    "bindPassword": "ldapPassword123"
    "bindPassword": "********"

    @PhoenixHe-msft Could you guide on how to fix the issue ?

    @brpanask
    Copy link
    Contributor Author

    ould you guide on how to fix the issue ?

    @PhoenixHe-msft Hi, Can you let me know what to do with this issue, I'd like to get this resolved soon.
    Thanks.

    @brpanask
    Copy link
    Contributor Author

    ould you guide on how to fix the issue ?

    @PhoenixHe-msft Hi, Can you let me know what to do with this issue, I'd like to get this resolved soon.
    Thanks.

    @jianyexi
    Is there anyone else that could help with this?

    @PhoenixHe-NV
    Copy link
    Contributor

    PhoenixHe-NV commented Dec 23, 2020 •
    edited
    Loading

    You could use "bindPassword": "<bindPassword>"

    @brpanask brpanask removed the DoNotMerge <valid label in PR review process> use to hold merge after approval label Dec 24, 2020
    @brpanask
    Copy link
    Contributor Author

    @jianyexi
    I removed the do not merge. The cred scan is passing.
    This is ready to be merged.
    Thanks.

    @jianyexi jianyexi merged commit 17644ec into Azure:master Dec 25, 2020
    This was referenced Dec 25, 2020
    Closed
    Closed
    Closed
    Closed
    Closed
    Merged
    Closed
    Closed
    Closed
    xiangyan99 added a commit that referenced this pull request Jan 5, 2021
    @xiangyan99 @napolish
    @arpja @ShaniFelig @Incarnation-p-lee @zachraMSFT @surashed @00Kai0 @zhenglaizhang @om-nishant @ihvo @ruowan @juhee0202 @xiazhan @kairu-ms @ericshape @andyzhangx @guy-microsoft @poanchen @ArcturusZhang @nemijato @brpanask @raych1 @aelij @david-msft @hotsnr @msyyc @xinyi-joffre @roytan-microsoft @vfedonkin @solankisamir @maksimkim @promoisha @RupengLiu @dcepelik @mudit794 @dhawal777 @MichalHel @jochav @rikogeln @chgennar @hivyas @leedouglas @cataggar @LingyunSu @elabicha @nimengan @juniwang @dagoroz @Sandido @yashmuel
    Get latest master (#12289)
    d3023cc 
    * [Hub Generated] Review request for Microsoft.AlertsManagement to add version stable/2019-06-01 (#11833)

* Changing Swagger file

* Changing examples

* Fixing tags example

* Fixing tags example

* Fixing tags example

* prettier fix for white spaces

* Enable azure-sdk-for-net-track2 (#12169)

* Updating existing CRR APIs with zone restore feature (#12157)

* - Added change for support of cross zone restores.

* - updating example json

* - Fixing prettier

* lastUpdatedDate for templates (#11900)

* lastUpdatedDate for templates

* fix

* [Hub Generated] Review request for Microsoft.AppPlatform to add version preview/2020-11-01-preview (#11823)

* Adds base for updating Microsoft.AppPlatform from version stable/2020-07-01 to version 2020-11-01-preview

* Updates readme

* Updates API version in new specs and examples

* Introduce additional change to 2020-11-01-preview.

* Additional properties to monitoringSettings.
* Readonly properties to requiredTraffics.

Signed-off-by: Pan Li <panli@microsoft.com>

* Make credscan happy.

Signed-off-by: Pan Li <panli@microsoft.com>

* [Hub Generated] Review request for Microsoft.Consumption to add version stable/2019-10-01 (#12113)

* Fix linter and swagger warnings

* Fix errors

* Removed unneeded change

* [ASC.Automations] Add new data type "RegulatoryComplianceAssessment" (#12185)

* Add SubAssessment event source type and add more automations examples

* Change Location isReadOnlu to false

* Test

* Add new read/write location and add new type TrackedResourceLocation

* Minor

* minor

* prettier fixes

* Change variable name to TrackedResourceLocation

* Change type name TrackedResourceLocation to AzureTrackedResourceLocation

* Update automations example

* Add SecureScores & SecureScoreControls as new supported datatypes in Automations resource

* [ASC.Automations] add new data type RegulatoryComplianceAssessment

* add datalake store track2 config (#12186)

* cleanup old pipeline dependencies (#11889)

* cleanup pipeline deps

* add rest-api-specs-scripts

* Extending recovery network input in replication intent API to support new network creation (#12191)

* [Hub Generated] Review request for Microsoft.Maps to add version preview/2020-02-01-preview (#12172)

* Adding operations for Maps Creator resource.

* Fixing typo.

* Adds suppression to readme

* Adds suppression to readme

* Adds suppression to readme

* Adds suppression to readme

* Resolving linter errors.

* Minor update.

* Updating all reference to v2 schema.

* Marked private atlas as deprecated in description.

* add operationsmanagement track2 config (#12141)

* Update comment.yml (#12202)

Add ARM traffic query link. When add breakingChangeReviewRequired

* Adding new properties to response body (#12201)

* adding new properties

* updating examples

* prettier fix

* [Hub Generated] Review request for Microsoft.ContainerService to add version stable/2020-12-01 (#12064)

* Add autorest.az configurations for azure monitor control service (#12090)

* add AMCS config for codegen

* reorganize command group

* rename command group

* Codegen modify try to rename DataCollectionRules create parameters

* hide DataCollectionRules Create & Update commands and DataCollectionRuleAssociations Create command

* use alias instand of rename in code-gen

* use monitor-control-service as the extension name

* Update readme.python.md

* add logic track2 config (#12166)

* add alertsmanagement track2 config (#11759)

* Update comment.yml (#12213)

* add mixedreality track2 confi (#12070)

* add signalr track2 config (#11892)

* add cognitiveservice track2 config (#11498)

* add machinglearningservices track2 config (#12183)

* add apimanagement track2 config (#12187)

* add serialconsole track2 config (#12046)

* Update TransparentDataEncryption Group Name (#12160)

* update TransparentDataEncryption Group name

* update reference of TransparentDataEncryption

* Update readme.python.md (#12216)

* Required changes for Azure HealthBot swagger (#12124)

* Fixes for SDK generation files.

* Fixes for SDK generation files.

* Added GO.

* Change Healthcare bot to Healthbot.

* 1. Remove unused properties of SKU.
2. Removed unused CheckNameAvailability.json
3. Remove subgroup.

* Sku is required.

* [Hub Generated] Review request for Microsoft.IoTCentral to add version stable/2018-09-01 (#12224)

* update to name

* update

* add api-version of guest configuration to go SDK (#12217)

* add api-version for templatespecs (#12197)

* Update specificationRepositoryConfiguration.json (#12218)

* Adding new api version to devops RP (#11585)

* Initial commit as per PR review

* Actual changes to api spec for new version

* Switching to multi-api build for python

* Fix python spec to correct namespaces in multiapi mode

* Revert changes to python generation

* Add systemdata

* Fix the path for sys data reference

* Fix path once more

* remove additional properties after including systemdata

* Remove more addtional properties

* Move system data to root

* Fix wrong output-folder (#12229)

* Remove swagger and examples because the controller will be used for private preview. (#12177)

* Update pull_request_assignment.yml (#12230)

* [Hub Generated] Review request for Microsoft.StorageCache to add version stable/2020-10-01 (#11407)

* Init the next version so diffs can work better.

* Updates readme

* Updates API version in new specs and examples

* Updates to StorageTargetProperties and added examples of cmk, mtu

Add 202 to the storage cache and storage target create/update and update examples

Fix ST no junction example's 202 response.

add properties for nfs extended groups

fix issues with extended groups properties found with autorest

add properties and objects for Active Directory username download

undo unintended change

changes from comments in pull request

AccessPolicy support.

Example fixes for Access Policies.

Fix attribute names to match latest RP.

update to credential properties for LDAP and Active Directory

marking password properties with x-ms-secret tag

minor changes on extended groups and add examples

Added blob NFS and some other validation fixes.

Update required property for domainName from dnsName

Updated blobNfs examples and some kpi fixes.

Correct validation errors in examples.

Added systemdata to resources.

Remove x-ms-secret in keyvault reference due to linter error and common types not using it.

Remove blobNfs from this version.

Remove blobNfs from spec file.

Remove x-ms-secret due to linter errors.

Fix certificate spelling.

Updating prettier and spell check errors.

Used prettier on main spec file.

Readded x-ms-secret that open api hub failed on but the PR pipeline allows.

* Add prettier fix after rebase

* Remove 202 bodies and add systemData to examples.

* Update spec with prettier.

* Address comments on spec for descriptions, readmes, and extendedGroupsEnabled.

* Updating to address addition ldap and pattern comments.

* Update version tag to include 01

* Restore changes that would be considered breaking changes matching 2020-03-01

* Address a few other comments.

* Update netbios field names and some descriptions.

* Fix s360 for missing debugInfo operation.

* Fix credscan error in example file.

* Update required fields, new validator failure on debugInfo return codes, and bindPassword example value.

* Update debug info example with new return codes.

* Update other credscan password errors.

* Update Semantic-and-Model-Violations-Reference.md (#12199)

Adding secret_property code, update some other codes.

* ADP - add system metadata to dataPool (#12179)

* Swagger Linting Fix (#12162)

* Fix Linting Issuing

* no message

* fix description

* add description and object back

* test to resolve model validation test

(cherry picked from commit ab273df)

* [SQL][V20180601] Updating LocationCapabilities spec (#12032)

* [SQL][V20180601] Updating LocationCapabilities spec

* Fill 2020 versions

* Rollback V2018 changes and bump LocationCapabilities in V4 to 2020-08-01-preview

* update order for CI-FixRequiredOnFailure (#12227)

* update rdbms track2 config (#12245)

* ADT: refix path (#12161)

* python track2 configure (#12150)

* Add and remove owner for service principals (#12081)

* [Hub Generated] Review request for Microsoft.MixedReality to add version stable/2020-05-01 (#11810)

* fix spec

* fix prettier

* [Hub Generated] Review request for Microsoft.MixedReality to add version preview/2019-12-02-preview (#11769)

* fix for swagger completeness

* forgot curly brace

* fix example

* Api Management - make /tenant endpoints ARM compliant in 2020-06-01-preview version (#11549)

* Adds base for updating Microsoft.ApiManagement from version stable/2019-12-01 to version 2020-06-01-preview

* Updates readme

* Updates API version in new specs and examples

* Add support in API Management for Availability Zones (#10284)

* apim in azs

* fix prettier check

* PATCH should return 200 OK (#10328)

* add support for PATCH returning 200 OK

* CI fixes

prettier fix

CI fixes part 2

* Password no longer a mandatory property when uploading Certificates

* add missing x-ms-odata extension for filter support

* +gatewayhostnameconfiguration protocol changes (#10292)

* [2020-06-01-preview] Update Oauth Server secrets Contract (#10602)

* Oauth server secrets contract

* fix azureMonitor enum

* API Management Service Deleted Services Resource (#10607)

* API Management Service Deleted Services Resource

* Path fix

* Lint + custom-words fixes

* Location URI parameter for deletedservices Resource

* GET for deletedservices by service name

* Remove resourceGroupName from resource path

* fixes

* schema for purge operation

* perttier applied

* 204 response code added

Co-authored-by: REDMOND\glfeokti <glfeokti@microsoft.com>

* OperationNameFormat property added to Diagnostic contract (#10641)

* OperationNameFormat property added to Diagnostic contract

* add azuremonitor to update contract

Co-authored-by: REDMOND\glfeokti <glfeokti@microsoft.com>

* [Microsoft.ApiManagement][2020-06-01-preview] Change Network Status response contract (#10331)

* Change Network Status response contract

* Update examples for network status contract

* ApiManagement - tenant/settings endpoints

* ApiManagement - tenant/settings endpoints fix

* ApiManagement - tenant/settings endpoints fix prettier

* ApiManagement - tenant/settings endpoints fix 3

* ApiManagement - tenant/settings endpoints fix 4

* ApiManagement - tenant/settings endpoints fix 5

Co-authored-by: Samir Solanki <samirsolanki@outlook.com>
Co-authored-by: maksimkim <maksim.kim@gmail.com>
Co-authored-by: promoisha <feoktistovgg@gmail.com>
Co-authored-by: REDMOND\glfeokti <glfeokti@microsoft.com>
Co-authored-by: RupengLiu <rliu1211@terpmail.umd.edu>
Co-authored-by: vfedonkin <vifedo@microsoft.com>

* Add "mail" parameter to UserUpdateParameters in graphrbac (#12127)

This patch adds a single optional field "mail" to UserUpdateParameters
schema. This makes it possible to update user's e-mail address using
the (Go) Azure SDK. Currently this is not possible.

I have curled the graphrbac API with the extra body parameter and it
works as expected.

Addition of the field will make it possible to support the mail property
on the azuread_user resource in terraform-provider-azuread.

Co-authored-by: David Čepelík <david.cepelik@showmax.com>

* [Hub Generated] Review request for Microsoft.Advisor to add version stable/2020-01-01 (#12262)

* add resourcegraph track2 config (#12122)

* add reservations track2 config (#12027)

* Removing a readonly tag from a property (#12254)

* Fix swagger correctness errors (#12246)

* Fix swagger correctness issues in Security for Iot service

* changed int format from 32 to 64

* Add systemData to iotSecuritySolutions

Co-authored-by: Liran Chen <lirche@microsoft.com>

* [Hub Generated] Review request for Microsoft.Consumption to add version stable/2019-10-01 (#12196)

* AAS - Swagger Linting and Correctness Fix (#12176)

* Fix R4013 IntegerTypeMustHaveFormat

* Fix R4010 RequiredDefaultResponse

* Fix R4007 DefaultErrorResponseSchema

* removed extra bracket

* fix semantic issue

* add type error

* Fix linting issue

* test to resolve model validation test

* Revert "test to resolve model validation test"

This reverts commit ab273df.

* Resolve Model Validation Issue

* Resolve Model Validation Issue v2

* test - add missing properties

(cherry picked from commit 48ec27c)

* fix format

* set default value

* add x-ms-enum

* fix nit

* Add missing property

* add missing properties

* add missing bracket

* change GatewayListStatusLive type

* add missing "origin" property

* fix model validation

* Revert "change GatewayListStatusLive type"

This reverts commit 4f3fa74.

* Revert "fix model validation"

This reverts commit 945bc23.

* add redhatopenshift track2 config (#12045)

* [Hub Generated] Review request for Microsoft.CostManagement to add version stable/2019-10-01 (#12194)

* Adding nextLink and previousLink to Tags endpoint properties

* moving properties out

* prettier check fix

Co-authored-by: Jorge Chavez Nieto <jochav@microsoft.com>

* add relay track2 config (#11495)

* update healthbot t2 config (#12269)

* update healthbot t2 config

* fix readme

* add automation track2 config (#11628)

* add automation track2 config

* update config

* Azure Remote Rendering REST API swagger file - for review (#12015)

* Azure Remote Rendering API specifcation

* fix schema issue

* fix examples

* fix request bodies integer values, :stop path

* pointing readme.md to open api spec for ARR

* fix typo, add custom words

* add msvc to custom words

* fix readme.md

* ran prettifier

* fix reference to json

* reference sts from file as well

* fix readme.md

* changes to readme.md

* remove example from error to fix error

* add 200 OK status for retried PUT for conversions and sessiosn

* ran prettier

* make autorest linter not crash

* fix casing of nextLinkName paramter

* factor out conversion list response

* add examples for conversions

* adding examples for sessions, prettify files

* [Hub Generated] Review request for Microsoft.Maps/Microsoft.Maps to add version preview/2.0 (#12175)

* microsoft.imagery 512 not supported

Adding micorosft.imagery to 512 tile not supported list

* Updating Raster Tilesets to Have Max Zoom 22

Certain raster tilesets now support up to zoom level 22.

* minor changes to swagger (#12253)

* minor changes to swagger

* reverting sdk definitions file

* Add addons to AVS 2020-07-17-preview (#12236)

* found missing AVS/privateclouds/addons commit, moving it to 2020-07-17-preview API from PR repo

* fixed prettier errors

* Fixed vladation warnings for x-ms-enum and missing description/title, related to addons

* fixed validation error for missing systemData for addons responses

* fixed prettier errors

* fixed validation error for missing systemData for addons responses

* systemData for any Resource

* make sure systemData is readOnly

* systemData needs to go in a new api version

* suppress systemData error

Co-authored-by: Cameron Taggart <cameron.taggart@microsoft.com>

* Azs api bug fix (#12133)

* Old api version for ComputeOperationResult

* Api Bugfix for Azure Stack Fabric Admin

* Fix for typo in readme

* Add default reponse

* Fix example issue for default error

* Update comment.yml (#12273)

* [Hub Generated] Review request for Microsoft.CostManagement to add version stable/2019-11-01 (#12031)

* fix dataSet typo

* fix dimensions and tags typo

* more dimensions and tags to fix

* one more miss on dimensions and tags

* Add the includeMonetaryCommitment missing field

* fix spell check error

* make property read only

* remove the not operation from query filters

* New backup service api version (#12171)

* Initial commit: adding new api version

* - new api 2020-12-01

* updating the readme.md package reference

* - adding the zone information for new api

* - updating api-version in examples
- added 'zone' in Get recoverypoint api example json

* Fixing prettier issue

* Revert "- updating api-version in examples"

This reverts commit 80baa9f.

* - adding api-version in examples

* adding new api version in package mds

* [IotHub] Introducing networkRuleSets in IotHubProperties [2020-08-31 : preview and stable ] (#10853)

* Adds base for updating Microsoft.Devices from version preview/2020-07-10-preview to version 2020-08-31-preview

* Updates readme

* Updates API version in new specs and examples

* Adds base for updating Microsoft.Devices from version stable/2020-08-01 to version 2020-08-31

* Updates readme

* Updates API version in new specs and examples

* Adding networkRuleSets support for iothub

* Adding networkRuleSets Support in preview version

* Adding Examples, correcting order in iothub.json

* Updating Readme to have stable and previe versions

* Modifying Tag to package-2020-08-31

* Adding Arm identity properties from 2020-07-010-preview version

* Removing creds

* minor fix

* swagger correctness fix (#12101)

* swagger correctness fix

* update preview version too

* Revert change and add defaults (#12243)

* Remove gallery preview version 2020-09-30 from stable release (#12222)

* add managementpartner track2 config (#12043)

* [Hub Generated] Review request for Microsoft.Insights to add version stable/2019-03-01 (#12232)

* Fixed swagger validations for api version 2019

* reverted error response change and suppress

* removed redundant error details

* renamed suppression rule

* fixed suppression

Co-authored-by: napolish <67951636+napolish@users.noreply.github.com>
Co-authored-by: Phoenix He <tih@microsoft.com>
Co-authored-by: arpja <46751982+arpja@users.noreply.github.com>
Co-authored-by: ShaniFelig <74960756+ShaniFelig@users.noreply.github.com>
Co-authored-by: Pan Li <Incarnation-p-lee@users.noreply.github.com>
Co-authored-by: Zach Rathbun <zachra@microsoft.com>
Co-authored-by: surashed <55134940+surashed@users.noreply.github.com>
Co-authored-by: Kaihui (Kerwin) Sun <sunkaihuisos@gmail.com>
Co-authored-by: Zhenglai Zhang <darinzh@microsoft.com>
Co-authored-by: om-nishant <50401171+om-nishant@users.noreply.github.com>
Co-authored-by: Ihar Voitka <ihvo@users.noreply.github.com>
Co-authored-by: Ruoxuan Wang <52271048+ruowan@users.noreply.github.com>
Co-authored-by: Ju Hee Lee <juhee0202@gmail.com>
Co-authored-by: xiazhan <allan.zhang76@gmail.com>
Co-authored-by: kai ru <69238381+kairu-ms@users.noreply.github.com>
Co-authored-by: Ji Wang <jiwang5@microsoft.com>
Co-authored-by: Andy Zhang <xiazhang@microsoft.com>
Co-authored-by: guy-microsoft <50947884+guy-microsoft@users.noreply.github.com>
Co-authored-by: PoAn (Baron) Chen <chen.baron@hotmail.com>
Co-authored-by: Arcturus <dapzhang@microsoft.com>
Co-authored-by: suyash691 <suyash691@github.com>
Co-authored-by: nemijato <68876730+nemijato@users.noreply.github.com>
Co-authored-by: brpanask <64860651+brpanask@users.noreply.github.com>
Co-authored-by: Ray Chen <raychen@microsoft.com>
Co-authored-by: Eli Arbel <aelij@arbel.net>
Co-authored-by: David Han <76010854+david-msft@users.noreply.github.com>
Co-authored-by: Roman Khotsyn <rokhot@microsoft.com>
Co-authored-by: David R. Williamson <drwill@microsoft.com>
Co-authored-by: msyyc <70930885+msyyc@users.noreply.github.com>
Co-authored-by: Xinyi Joffre <xiou@microsoft.com>
Co-authored-by: roytan-microsoft <73565668+roytan-microsoft@users.noreply.github.com>
Co-authored-by: Vitaliy Fedonkin <vitaliy.fedonkin@gmail.com>
Co-authored-by: Samir Solanki <samirsolanki@outlook.com>
Co-authored-by: maksimkim <maksim.kim@gmail.com>
Co-authored-by: promoisha <feoktistovgg@gmail.com>
Co-authored-by: REDMOND\glfeokti <glfeokti@microsoft.com>
Co-authored-by: RupengLiu <rliu1211@terpmail.umd.edu>
Co-authored-by: vfedonkin <vifedo@microsoft.com>
Co-authored-by: David Čepelík <d@dcepelik.cz>
Co-authored-by: David Čepelík <david.cepelik@showmax.com>
Co-authored-by: mudit794 <42189950+mudit794@users.noreply.github.com>
Co-authored-by: Dhawal Jain <41853104+dhawal777@users.noreply.github.com>
Co-authored-by: MichalHel <51286657+MichalHel@users.noreply.github.com>
Co-authored-by: Liran Chen <lirche@microsoft.com>
Co-authored-by: jochav <75458295+jochav@users.noreply.github.com>
Co-authored-by: Jorge Chavez Nieto <jochav@microsoft.com>
Co-authored-by: rikogeln <40666347+rikogeln@users.noreply.github.com>
Co-authored-by: chgennar <56695749+chgennar@users.noreply.github.com>
Co-authored-by: hivyas <61890270+hivyas@users.noreply.github.com>
Co-authored-by: Douglas Lee <65295939+leedouglas@users.noreply.github.com>
Co-authored-by: Cameron Taggart <cameron.taggart@microsoft.com>
Co-authored-by: LingyunSu <33764806+LingyunSu@users.noreply.github.com>
Co-authored-by: elabicha <61994320+elabicha@users.noreply.github.com>
Co-authored-by: Nikhil Kumar Mengani <62704762+nimengan@users.noreply.github.com>
Co-authored-by: Junbo Wang <juniwang@microsoft.com>
Co-authored-by: Daniel Orozco <64658732+dagoroz@users.noreply.github.com>
Co-authored-by: Adam Sandor <adsandor@microsoft.com>
Co-authored-by: yashmuel <63585146+yashmuel@users.noreply.github.com>
    josuhazure pushed a commit to josuhazure/azure-rest-api-specs that referenced this pull request Jan 6, 2021
    @brpanask
    [Hub Generated] Review request for Microsoft.StorageCache to add vers…
    bfc33ba 
    …ion stable/2020-10-01 (Azure#11407)

* Init the next version so diffs can work better.

* Updates readme

* Updates API version in new specs and examples

* Updates to StorageTargetProperties and added examples of cmk, mtu

Add 202 to the storage cache and storage target create/update and update examples

Fix ST no junction example's 202 response.

add properties for nfs extended groups

fix issues with extended groups properties found with autorest

add properties and objects for Active Directory username download

undo unintended change

changes from comments in pull request

AccessPolicy support.

Example fixes for Access Policies.

Fix attribute names to match latest RP.

update to credential properties for LDAP and Active Directory

marking password properties with x-ms-secret tag

minor changes on extended groups and add examples

Added blob NFS and some other validation fixes.

Update required property for domainName from dnsName

Updated blobNfs examples and some kpi fixes.

Correct validation errors in examples.

Added systemdata to resources.

Remove x-ms-secret in keyvault reference due to linter error and common types not using it.

Remove blobNfs from this version.

Remove blobNfs from spec file.

Remove x-ms-secret due to linter errors.

Fix certificate spelling.

Updating prettier and spell check errors.

Used prettier on main spec file.

Readded x-ms-secret that open api hub failed on but the PR pipeline allows.

* Add prettier fix after rebase

* Remove 202 bodies and add systemData to examples.

* Update spec with prettier.

* Address comments on spec for descriptions, readmes, and extendedGroupsEnabled.

* Updating to address addition ldap and pattern comments.

* Update version tag to include 01

* Restore changes that would be considered breaking changes matching 2020-03-01

* Address a few other comments.

* Update netbios field names and some descriptions.

* Fix s360 for missing debugInfo operation.

* Fix credscan error in example file.

* Update required fields, new validator failure on debugInfo return codes, and bindPassword example value.

* Update debug info example with new return codes.

* Update other credscan password errors.
    @brpanask brpanask deleted the dev-storagecache-Microsoft.StorageCache-2020-10-01 branch January 29, 2021 20:21
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Reviewers

    @romahamu romahamu romahamu left review comments

    @omzevall omzevall omzevall left review comments

    @JeffreyRichter JeffreyRichter JeffreyRichter approved these changes

    @mannywarrior mannywarrior mannywarrior approved these changes

    @majastrz majastrz majastrz approved these changes

    @jianyexi jianyexi jianyexi approved these changes

    @lirenhe lirenhe Awaiting requested review from lirenhe

    Assignees

    @jianyexi jianyexi

    Labels
    Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review CI-BreakingChange-Python
    Projects
    None yet
    Milestone
    No milestone
    Development

    Successfully merging this pull request may close these issues.
    9 participants
    @brpanask @romahamu @PhoenixHe-NV @jianyexi @ArcturusZhang @JeffreyRichter @mannywarrior @majastrz @omzevall