Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Semantic-and-Model-Violations-Reference.md #12199

Merged
merged 1 commit into from
Dec 28, 2020
Merged

Conversation

raych1
Copy link
Member

@raych1 raych1 commented Dec 22, 2020

Adding secret_property code, update some other codes.

Adding secret_property code, update some other codes.
@openapi-workflow-bot
Copy link

Hi, @raych1 Thanks for your PR. I am workflow bot for review process. Here are some small tips.

  • Please ensure to do self-check against checklists in first PR comment.
  • PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.
  • For specs comparison cross API versions, Use API Specs Comparison Report Generator
  • If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

  • Any feedback about review process or workflow bot, pls contact swagger and tools team. vsswagger@microsoft.com

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Dec 22, 2020

    Swagger Validation Report

    ️️✔️BreakingChange succeeded [Detail] [Expand]
    There are no breaking changes.
    ️️✔️LintDiff succeeded [Detail] [Expand]
    Validation passes for LintDiff.
    ️️✔️Avocado succeeded [Detail] [Expand]
    Validation passes for Avocado.
    ️️✔️ModelValidation succeeded [Detail] [Expand]
    Validation passes for ModelValidation.
    ️️✔️SemanticValidation succeeded [Detail] [Expand]
    Validation passes for SemanticValidation.
    ️️✔️[Staging] Cross Version BreakingChange (Base on preview version) succeeded [Detail] [Expand]
    There are no breaking changes.
    ️️✔️[Staging] Cross Version BreakingChange (Base on stable version) succeeded [Detail] [Expand]
    There are no breaking changes.
    ️️✔️CredScan succeeded [Detail] [Expand]
    There is no credential detected.
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Dec 22, 2020

    Swagger pipeline restarted successfully, please wait for status update in this comment.

    @raych1 raych1 merged commit 34c2f7e into master Dec 28, 2020
    xiangyan99 added a commit that referenced this pull request Jan 5, 2021
    * [Hub Generated] Review request for Microsoft.AlertsManagement to add version stable/2019-06-01 (#11833)
    
    * Changing Swagger file
    
    * Changing examples
    
    * Fixing tags example
    
    * Fixing tags example
    
    * Fixing tags example
    
    * prettier fix for white spaces
    
    * Enable azure-sdk-for-net-track2 (#12169)
    
    * Updating existing CRR APIs with zone restore feature (#12157)
    
    * - Added change for support of cross zone restores.
    
    * - updating example json
    
    * - Fixing prettier
    
    * lastUpdatedDate for templates (#11900)
    
    * lastUpdatedDate for templates
    
    * fix
    
    * [Hub Generated] Review request for Microsoft.AppPlatform to add version preview/2020-11-01-preview (#11823)
    
    * Adds base for updating Microsoft.AppPlatform from version stable/2020-07-01 to version 2020-11-01-preview
    
    * Updates readme
    
    * Updates API version in new specs and examples
    
    * Introduce additional change to 2020-11-01-preview.
    
    * Additional properties to monitoringSettings.
    * Readonly properties to requiredTraffics.
    
    Signed-off-by: Pan Li <panli@microsoft.com>
    
    * Make credscan happy.
    
    Signed-off-by: Pan Li <panli@microsoft.com>
    
    * [Hub Generated] Review request for Microsoft.Consumption to add version stable/2019-10-01 (#12113)
    
    * Fix linter and swagger warnings
    
    * Fix errors
    
    * Removed unneeded change
    
    * [ASC.Automations] Add new data type "RegulatoryComplianceAssessment" (#12185)
    
    * Add SubAssessment event source type and add more automations examples
    
    * Change Location isReadOnlu to false
    
    * Test
    
    * Add new read/write location and add new type TrackedResourceLocation
    
    * Minor
    
    * minor
    
    * prettier fixes
    
    * Change variable name to TrackedResourceLocation
    
    * Change type name TrackedResourceLocation to AzureTrackedResourceLocation
    
    * Update automations example
    
    * Add SecureScores & SecureScoreControls as new supported datatypes in Automations resource
    
    * [ASC.Automations] add new data type RegulatoryComplianceAssessment
    
    * add datalake store track2 config (#12186)
    
    * cleanup old pipeline dependencies (#11889)
    
    * cleanup pipeline deps
    
    * add rest-api-specs-scripts
    
    * Extending recovery network input in replication intent API to support new network creation (#12191)
    
    * [Hub Generated] Review request for Microsoft.Maps to add version preview/2020-02-01-preview (#12172)
    
    * Adding operations for Maps Creator resource.
    
    * Fixing typo.
    
    * Adds suppression to readme
    
    * Adds suppression to readme
    
    * Adds suppression to readme
    
    * Adds suppression to readme
    
    * Resolving linter errors.
    
    * Minor update.
    
    * Updating all reference to v2 schema.
    
    * Marked private atlas as deprecated in description.
    
    * add operationsmanagement track2 config (#12141)
    
    * Update comment.yml (#12202)
    
    Add ARM traffic query link. When add breakingChangeReviewRequired
    
    * Adding new properties to response body (#12201)
    
    * adding new properties
    
    * updating examples
    
    * prettier fix
    
    * [Hub Generated] Review request for Microsoft.ContainerService to add version stable/2020-12-01 (#12064)
    
    * Add autorest.az configurations for azure monitor control service (#12090)
    
    * add AMCS config for codegen
    
    * reorganize command group
    
    * rename command group
    
    * Codegen modify try to rename DataCollectionRules create parameters
    
    * hide DataCollectionRules Create & Update commands and DataCollectionRuleAssociations Create command
    
    * use alias instand of rename in code-gen
    
    * use monitor-control-service as the extension name
    
    * Update readme.python.md
    
    * add logic track2 config (#12166)
    
    * add alertsmanagement track2 config (#11759)
    
    * Update comment.yml (#12213)
    
    * add mixedreality track2 confi (#12070)
    
    * add signalr track2 config (#11892)
    
    * add cognitiveservice track2 config (#11498)
    
    * add machinglearningservices track2 config (#12183)
    
    * add apimanagement track2 config (#12187)
    
    * add serialconsole track2 config (#12046)
    
    * Update TransparentDataEncryption Group Name (#12160)
    
    * update TransparentDataEncryption Group name
    
    * update reference of TransparentDataEncryption
    
    * Update readme.python.md (#12216)
    
    * Required changes for Azure HealthBot swagger (#12124)
    
    * Fixes for SDK generation files.
    
    * Fixes for SDK generation files.
    
    * Added GO.
    
    * Change Healthcare bot to Healthbot.
    
    * 1. Remove unused properties of SKU.
    2. Removed unused CheckNameAvailability.json
    3. Remove subgroup.
    
    * Sku is required.
    
    * [Hub Generated] Review request for Microsoft.IoTCentral to add version stable/2018-09-01 (#12224)
    
    * update to name
    
    * update
    
    * add api-version of guest configuration to go SDK (#12217)
    
    * add api-version for templatespecs (#12197)
    
    * Update specificationRepositoryConfiguration.json (#12218)
    
    * Adding new api version to devops RP (#11585)
    
    * Initial commit as per PR review
    
    * Actual changes to api spec for new version
    
    * Switching to multi-api build for python
    
    * Fix python spec to correct namespaces in multiapi mode
    
    * Revert changes to python generation
    
    * Add systemdata
    
    * Fix the path for sys data reference
    
    * Fix path once more
    
    * remove additional properties after including systemdata
    
    * Remove more addtional properties
    
    * Move system data to root
    
    * Fix wrong output-folder (#12229)
    
    * Remove swagger and examples because the controller will be used for private preview. (#12177)
    
    * Update pull_request_assignment.yml (#12230)
    
    * [Hub Generated] Review request for Microsoft.StorageCache to add version stable/2020-10-01 (#11407)
    
    * Init the next version so diffs can work better.
    
    * Updates readme
    
    * Updates API version in new specs and examples
    
    * Updates to StorageTargetProperties and added examples of cmk, mtu
    
    Add 202 to the storage cache and storage target create/update and update examples
    
    Fix ST no junction example's 202 response.
    
    add properties for nfs extended groups
    
    fix issues with extended groups properties found with autorest
    
    add properties and objects for Active Directory username download
    
    undo unintended change
    
    changes from comments in pull request
    
    AccessPolicy support.
    
    Example fixes for Access Policies.
    
    Fix attribute names to match latest RP.
    
    update to credential properties for LDAP and Active Directory
    
    marking password properties with x-ms-secret tag
    
    minor changes on extended groups and add examples
    
    Added blob NFS and some other validation fixes.
    
    Update required property for domainName from dnsName
    
    Updated blobNfs examples and some kpi fixes.
    
    Correct validation errors in examples.
    
    Added systemdata to resources.
    
    Remove x-ms-secret in keyvault reference due to linter error and common types not using it.
    
    Remove blobNfs from this version.
    
    Remove blobNfs from spec file.
    
    Remove x-ms-secret due to linter errors.
    
    Fix certificate spelling.
    
    Updating prettier and spell check errors.
    
    Used prettier on main spec file.
    
    Readded x-ms-secret that open api hub failed on but the PR pipeline allows.
    
    * Add prettier fix after rebase
    
    * Remove 202 bodies and add systemData to examples.
    
    * Update spec with prettier.
    
    * Address comments on spec for descriptions, readmes, and extendedGroupsEnabled.
    
    * Updating to address addition ldap and pattern comments.
    
    * Update version tag to include 01
    
    * Restore changes that would be considered breaking changes matching 2020-03-01
    
    * Address a few other comments.
    
    * Update netbios field names and some descriptions.
    
    * Fix s360 for missing debugInfo operation.
    
    * Fix credscan error in example file.
    
    * Update required fields, new validator failure on debugInfo return codes, and bindPassword example value.
    
    * Update debug info example with new return codes.
    
    * Update other credscan password errors.
    
    * Update Semantic-and-Model-Violations-Reference.md (#12199)
    
    Adding secret_property code, update some other codes.
    
    * ADP - add system metadata to dataPool (#12179)
    
    * Swagger Linting Fix (#12162)
    
    * Fix Linting Issuing
    
    * no message
    
    * fix description
    
    * add description and object back
    
    * test to resolve model validation test
    
    (cherry picked from commit ab273df)
    
    * [SQL][V20180601] Updating LocationCapabilities spec (#12032)
    
    * [SQL][V20180601] Updating LocationCapabilities spec
    
    * Fill 2020 versions
    
    * Rollback V2018 changes and bump LocationCapabilities in V4 to 2020-08-01-preview
    
    * update order for CI-FixRequiredOnFailure (#12227)
    
    * update rdbms track2 config (#12245)
    
    * ADT: refix path (#12161)
    
    * python track2 configure (#12150)
    
    * Add and remove owner for service principals (#12081)
    
    * [Hub Generated] Review request for Microsoft.MixedReality to add version stable/2020-05-01 (#11810)
    
    * fix spec
    
    * fix prettier
    
    * [Hub Generated] Review request for Microsoft.MixedReality to add version preview/2019-12-02-preview (#11769)
    
    * fix for swagger completeness
    
    * forgot curly brace
    
    * fix example
    
    * Api Management - make /tenant endpoints ARM compliant in 2020-06-01-preview version (#11549)
    
    * Adds base for updating Microsoft.ApiManagement from version stable/2019-12-01 to version 2020-06-01-preview
    
    * Updates readme
    
    * Updates API version in new specs and examples
    
    * Add support in API Management for Availability Zones (#10284)
    
    * apim in azs
    
    * fix prettier check
    
    * PATCH should return 200 OK (#10328)
    
    * add support for PATCH returning 200 OK
    
    * CI fixes
    
    prettier fix
    
    CI fixes part 2
    
    * Password no longer a mandatory property when uploading Certificates
    
    * add missing x-ms-odata extension for filter support
    
    * +gatewayhostnameconfiguration protocol changes (#10292)
    
    * [2020-06-01-preview] Update Oauth Server secrets Contract (#10602)
    
    * Oauth server secrets contract
    
    * fix azureMonitor enum
    
    * API Management Service Deleted Services Resource (#10607)
    
    * API Management Service Deleted Services Resource
    
    * Path fix
    
    * Lint + custom-words fixes
    
    * Location URI parameter for deletedservices Resource
    
    * GET for deletedservices by service name
    
    * Remove resourceGroupName from resource path
    
    * fixes
    
    * schema for purge operation
    
    * perttier applied
    
    * 204 response code added
    
    Co-authored-by: REDMOND\glfeokti <glfeokti@microsoft.com>
    
    * OperationNameFormat property added to Diagnostic contract (#10641)
    
    * OperationNameFormat property added to Diagnostic contract
    
    * add azuremonitor to update contract
    
    Co-authored-by: REDMOND\glfeokti <glfeokti@microsoft.com>
    
    * [Microsoft.ApiManagement][2020-06-01-preview] Change Network Status response contract (#10331)
    
    * Change Network Status response contract
    
    * Update examples for network status contract
    
    * ApiManagement - tenant/settings endpoints
    
    * ApiManagement - tenant/settings endpoints fix
    
    * ApiManagement - tenant/settings endpoints fix prettier
    
    * ApiManagement - tenant/settings endpoints fix 3
    
    * ApiManagement - tenant/settings endpoints fix 4
    
    * ApiManagement - tenant/settings endpoints fix 5
    
    Co-authored-by: Samir Solanki <samirsolanki@outlook.com>
    Co-authored-by: maksimkim <maksim.kim@gmail.com>
    Co-authored-by: promoisha <feoktistovgg@gmail.com>
    Co-authored-by: REDMOND\glfeokti <glfeokti@microsoft.com>
    Co-authored-by: RupengLiu <rliu1211@terpmail.umd.edu>
    Co-authored-by: vfedonkin <vifedo@microsoft.com>
    
    * Add "mail" parameter to UserUpdateParameters in graphrbac (#12127)
    
    This patch adds a single optional field "mail" to UserUpdateParameters
    schema. This makes it possible to update user's e-mail address using
    the (Go) Azure SDK. Currently this is not possible.
    
    I have curled the graphrbac API with the extra body parameter and it
    works as expected.
    
    Addition of the field will make it possible to support the mail property
    on the azuread_user resource in terraform-provider-azuread.
    
    Co-authored-by: David Čepelík <david.cepelik@showmax.com>
    
    * [Hub Generated] Review request for Microsoft.Advisor to add version stable/2020-01-01 (#12262)
    
    * add resourcegraph track2 config (#12122)
    
    * add reservations track2 config (#12027)
    
    * Removing a readonly tag from a property (#12254)
    
    * Fix swagger correctness errors (#12246)
    
    * Fix swagger correctness issues in Security for Iot service
    
    * changed int format from 32 to 64
    
    * Add systemData to iotSecuritySolutions
    
    Co-authored-by: Liran Chen <lirche@microsoft.com>
    
    * [Hub Generated] Review request for Microsoft.Consumption to add version stable/2019-10-01 (#12196)
    
    * AAS - Swagger Linting and Correctness Fix (#12176)
    
    * Fix R4013 IntegerTypeMustHaveFormat
    
    * Fix R4010 RequiredDefaultResponse
    
    * Fix R4007 DefaultErrorResponseSchema
    
    * removed extra bracket
    
    * fix semantic issue
    
    * add type error
    
    * Fix linting issue
    
    * test to resolve model validation test
    
    * Revert "test to resolve model validation test"
    
    This reverts commit ab273df.
    
    * Resolve M