[OpenAI] Update JS tspconfig #24427

deyaaeldeen · 2023-06-13T22:34:29Z

Data Plane API - Pull Request

API Info: The Basics

Most of the information about your service should be captured in the issue that serves as your API Spec engagement record.

Link to API Spec engagement record issue:

Is this review for (select one):

a private preview
a public preview
GA release

Change Scope

^{This section will help us focus on the specific parts of your API that are new or have been modified.
Please share a link to the design document for the new APIs, a link to the previous API Spec document (if applicable), and the root paths that have been updated.}

Design Document:
Previous API Spec Doc:
Updated paths:

❔Got questions? Need additional info?? We are here to help!

Contact us!

The Azure API Review Board is dedicated to helping you create amazing APIs. You can read about our mission and learn more about our process on our wiki.

💬 Teams Channel
💌 email

Click here for links to tools, specs, guidelines & other good stuff

Tooling

Open API validation tools were run on this PR. Go here to see how to fix errors
Spectral Linting
Open API Hub

Guidelines & Specifications

Helpful Links

Azure DevTools Wiki

openapi-workflow-bot · 2023-06-13T22:34:33Z

Hi, @deyaaeldeen Thanks for your PR. I am workflow bot for review process. Here are some small tips.

Please ensure to do self-check against checklists in first PR comment.

PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.

For specs comparison cross API versions, Use API Specs Comparison Report Generator

If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

Any feedback about review process or workflow bot, pls contact swagger and tools team. vscswagger@microsoft.com

openapi-pipeline-app · 2023-06-13T22:34:33Z

Swagger Validation Report

️️✔️BreakingChange succeeded [Detail] [Expand]

There are no breaking changes.

️️✔️Breaking Change(Cross-Version) succeeded [Detail] [Expand]

There are no breaking changes.

️️✔️CredScan succeeded [Detail] [Expand]

There is no credential detected.

️️✔️LintDiff succeeded [Detail] [Expand]

Validation passes for LintDiff.

️️✔️Avocado succeeded [Detail] [Expand]

Validation passes for Avocado.

️️✔️ApiReadinessCheck succeeded [Detail] [Expand]

️️✔️~[Staging] ServiceAPIReadinessTest succeeded [Detail] [Expand]

Validation passes for ServiceAPIReadinessTest.

️️✔️SwaggerAPIView succeeded [Detail] [Expand]

️️✔️CadlAPIView succeeded [Detail] [Expand]

️️✔️TypeSpecAPIView succeeded [Detail] [Expand]

️️✔️ModelValidation succeeded [Detail] [Expand]

Validation passes for ModelValidation.

️️✔️SemanticValidation succeeded [Detail] [Expand]

Validation passes for SemanticValidation.

️️✔️PoliCheck succeeded [Detail] [Expand]

Validation passed for PoliCheck.

️️✔️PrettierCheck succeeded [Detail] [Expand]

Validation passes for PrettierCheck.

️️✔️SpellCheck succeeded [Detail] [Expand]

Validation passes for SpellCheck.

️️✔️Lint(RPaaS) succeeded [Detail] [Expand]

Validation passes for Lint(RPaaS).

️️✔️CadlValidation succeeded [Detail] [Expand]

Validation passes for CadlValidation.

️️✔️TypeSpec Validation succeeded [Detail] [Expand]

Validation passes for TypeSpec Validation.

️️✔️PR Summary succeeded [Detail] [Expand]

Validation passes for Summary.

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-pipeline-app · 2023-06-13T22:34:34Z

Swagger Generation Artifacts

️️✔️ApiDocPreview succeeded [Detail] [Expand]

️️✔️SDK Breaking Change Tracking succeeded [Detail] [Expand]

Breaking Changes Tracking

️❌ azure-sdk-for-net-track2 failed [Detail]

❌Failed [Logs] Generate from 61c7c5426050ec3b2ddb5ed8f732a75d3f1cd588. SDK Automation 14.0.0

command	pwsh ./eng/scripts/Automation-Sdk-Init.ps1 ../azure-sdk-for-net_tmp/initInput.json ../azure-sdk-for-net_tmp/initOutput.json
command	pwsh ./eng/scripts/Invoke-GenerateAndBuildV2.ps1 ../azure-sdk-for-net_tmp/generateInput.json ../azure-sdk-for-net_tmp/generateOutput.json
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1mGeneratePackage: �[0m/mnt/vss/_work/1/s/azure-sdk-for-net/eng/scripts/Invoke-GenerateAndBuildV2.ps1:131
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1mLine |
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m 131 | �[0m               �[36;1mGeneratePackage `�[0m
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m     | �[31;1m               ~~~~~~~~~~~~~~~~~
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1m�[36;1m     | �[31;1mFailed to build sdk. exit code: False
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[0m
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1mGeneratePackage: �[0m/mnt/vss/_work/1/s/azure-sdk-for-net/eng/scripts/Invoke-GenerateAndBuildV2.ps1:131
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1mLine |
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m 131 | �[0m               �[36;1mGeneratePackage `�[0m
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m     | �[31;1m               ~~~~~~~~~~~~~~~~~
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1m�[36;1m     | �[31;1mFailed to packe sdk. exit code: False
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[0m
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1mGet-ChildItem: �[0m/mnt/vss/_work/1/s/azure-sdk-for-net/eng/scripts/automation/GenerateAndBuildLib.ps1:805
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1mLine |
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m 805 | �[0m … rtifacts += �[36;1mGet-ChildItem $artifactsPath -Filter *.nupkg -exclude *.s�[0m …
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m     | �[31;1m               ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1m�[36;1m     | �[31;1mCannot find path
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m     | �[31;1m'/mnt/vss/_work/1/s/azure-sdk-for-net/artifacts/packages/Debug/' because
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m     | �[31;1mit does not exist.
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[0m
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1mGeneratePackage: �[0m/mnt/vss/_work/1/s/azure-sdk-for-net/eng/scripts/Invoke-GenerateAndBuildV2.ps1:131
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1mLine |
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m 131 | �[0m               �[36;1mGeneratePackage `�[0m
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m     | �[31;1m               ~~~~~~~~~~~~~~~~~
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1m�[36;1m     | �[31;1mFailed to generate sdk artifact
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[0m

❌Azure.AI.OpenAI [View full logs] [Preview SDK Changes]
```
info	[Changelog]
```

️⚠️ azure-sdk-for-java warning [Detail]

⚠️Warning [Logs] Generate from 61c7c5426050ec3b2ddb5ed8f732a75d3f1cd588. SDK Automation 14.0.0

command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
cmderr	[init.sh] [notice] A new release of pip is available: 23.0.1 -> 23.1.2
cmderr	[init.sh] [notice] To update, run: pip install --upgrade pip
cmderr	[init.sh] [notice] A new release of pip is available: 23.0.1 -> 23.1.2
cmderr	[init.sh] [notice] To update, run: pip install --upgrade pip
command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json
cmderr	[generate.py]
cmderr	[generate.py] npm notice New major version of npm available! 8.19.4 -> 9.8.0
cmderr	[generate.py] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v9.8.0>
cmderr	[generate.py] npm notice Run `npm install -g npm@9.8.0` to update!
cmderr	[generate.py] npm notice

️✔️azure-ai-openai [View full logs] [Preview SDK Changes]

️🔄 azure-sdk-for-js inProgress [Detail]

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-pipeline-app · 2023-06-13T22:34:35Z

Generated ApiView

Language	Package Name	ApiView Link
Java	azure-ai-openai	There is no API change compared with the previous version

raych1 · 2023-06-14T07:06:29Z

specification/cognitiveservices/OpenAI.Inference/tspconfig.yaml

    generateMetadata: false
    generateTest: false
    isModularLibrary: true
+    relative-generated-folder: "sources/generated"


Is this key only introduced for JS emitter? Can JS emitter leverage package-dir? This is the latest schema we're aligned and is rolling out.
#23866

Yes, it is being added in Azure/azure-sdk-for-js#26138.

I added the comment in the above PR. //CC: @weshaggard

Yes lets try to avoid this if possible. I'd prefer we simply append "sources/generated" to the package-dir path we are already computing instead of having folks need this property in their tspconfig file.

MaryGao · 2023-06-14T08:41:08Z

/azp run

azure-pipelines · 2023-06-14T08:41:20Z

Azure Pipelines successfully started running 1 pipeline(s).

MaryGao · 2023-06-14T08:51:53Z

specification/cognitiveservices/OpenAI.Inference/tspconfig.yaml

    generateMetadata: false
    generateTest: false
    isModularLibrary: true
+    relative-generated-folder: "sources/generated"


@deyaaeldeen Not sure you could try the command link in local to verify if the option works or not. Feel free to raise issue in codegen if not.

./eng/common/scripts/TypeSpec-Project-Process.ps1 /home/rc/repos/tmp/spec-repo/specification/contosowidgetmanager/Contoso.WidgetManager 677e272f33a3eaa724abd769af79383a5ac2bba5 https://github.com/Azure/azure-rest-api-specs

It is being added in Azure/azure-sdk-for-js#26138 and I verified it works.

Applied new schema of emitter options.

raych1 · 2023-06-20T03:28:05Z

@deyaaeldeen , I merged the change from main. The JS emitter was commented out in main, can you please double check?

xirzec · 2023-07-07T19:15:42Z

Closing this change, since I think we can accomplish what we want without adding yet another flag to the emitter.

[OpenAI] Update JS tspconfig

32107d9

deyaaeldeen requested review from mikeharder and m-nash June 13, 2023 22:34

deyaaeldeen requested a review from yangyuan as a code owner June 13, 2023 22:34

openapi-assignment-bot bot assigned weshaggard Jun 13, 2023

ghost added the Cognitive Services label Jun 13, 2023

mikeharder approved these changes Jun 13, 2023

View reviewed changes

raych1 reviewed Jun 14, 2023

View reviewed changes

MaryGao reviewed Jun 14, 2023

View reviewed changes

raych1 added 2 commits June 20, 2023 11:20

Update tspconfig.yaml

3447c32

Applied new schema of emitter options.

Merge branch 'main' into openai/js-update

29ff82b

Merge branch 'main' into openai/js-update

04bbdbf

This was referenced Jul 7, 2023

[AutoPR Azure.AI.OpenAI] [OpenAI] Update JS tspconfig azure-sdk/azure-sdk-for-net#4302

Closed

[AutoPR azure-ai-openai] [OpenAI] Update JS tspconfig azure-sdk/azure-sdk-for-java#5977

Closed

mpodwysocki mentioned this pull request Jul 7, 2023

[OpenAI] Add support for image generation Azure/azure-sdk-for-js#26138

Merged

xirzec closed this Jul 7, 2023

MaryGao mentioned this pull request Aug 1, 2023

Design customization process from typespec generation Azure/autorest.typescript#1950

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[OpenAI] Update JS tspconfig #24427

[OpenAI] Update JS tspconfig #24427

deyaaeldeen commented Jun 13, 2023

openapi-workflow-bot bot commented Jun 13, 2023

openapi-pipeline-app bot commented Jun 13, 2023 •

edited

Loading

openapi-pipeline-app bot commented Jun 13, 2023 •

edited

Loading

Breaking Changes Tracking

openapi-pipeline-app bot commented Jun 13, 2023 •

edited

Loading

raych1 Jun 14, 2023

deyaaeldeen Jun 14, 2023

raych1 Jun 16, 2023

weshaggard Jun 19, 2023

MaryGao commented Jun 14, 2023

azure-pipelines bot commented Jun 14, 2023

MaryGao Jun 14, 2023 •

edited

Loading

deyaaeldeen Jun 14, 2023

raych1 commented Jun 20, 2023

xirzec commented Jul 7, 2023

[OpenAI] Update JS tspconfig #24427

[OpenAI] Update JS tspconfig #24427

Conversation

deyaaeldeen commented Jun 13, 2023

Data Plane API - Pull Request

API Info: The Basics

Change Scope

❔Got questions? Need additional info?? We are here to help!

Tooling

Guidelines & Specifications

Helpful Links

openapi-workflow-bot bot commented Jun 13, 2023

openapi-pipeline-app bot commented Jun 13, 2023 • edited Loading

Swagger Validation Report

openapi-pipeline-app bot commented Jun 13, 2023 • edited Loading

Swagger Generation Artifacts

Breaking Changes Tracking

openapi-pipeline-app bot commented Jun 13, 2023 • edited Loading

Generated ApiView

raych1 Jun 14, 2023

Choose a reason for hiding this comment

deyaaeldeen Jun 14, 2023

Choose a reason for hiding this comment

raych1 Jun 16, 2023

Choose a reason for hiding this comment

weshaggard Jun 19, 2023

Choose a reason for hiding this comment

MaryGao commented Jun 14, 2023

azure-pipelines bot commented Jun 14, 2023

MaryGao Jun 14, 2023 • edited Loading

Choose a reason for hiding this comment

deyaaeldeen Jun 14, 2023

Choose a reason for hiding this comment

raych1 commented Jun 20, 2023

xirzec commented Jul 7, 2023

openapi-pipeline-app bot commented Jun 13, 2023 •

edited

Loading

openapi-pipeline-app bot commented Jun 13, 2023 •

edited

Loading

openapi-pipeline-app bot commented Jun 13, 2023 •

edited

Loading

MaryGao Jun 14, 2023 •

edited

Loading