[OpenAI] Update JS tspconfig #24427
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -23,11 +23,11 @@ options: | |
| partial-update: true | ||
| enable-sync-stack: true | ||
| generate-tests: false | ||
| "@azure-tools/typespec-ts": | ||
| package-dir: "openai" | ||
| generateMetadata: false | ||
| generateTest: false | ||
| isModularLibrary: true | ||
| relative-generated-folder: "sources/generated" | ||
|
There was a problem hiding this comment. @deyaaeldeen Not sure you could try the command link in local to verify if the option works or not. Feel free to raise issue in codegen if not. There was a problem hiding this comment. It is being added in Azure/azure-sdk-for-js#26138 and I verified it works. |
||
| packageDetails: | ||
| name: "@azure/openai" | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this key only introduced for JS emitter? Can JS emitter leverage
package-dir? This is the latest schema we're aligned and is rolling out.#23866
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, it is being added in Azure/azure-sdk-for-js#26138.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added the comment in the above PR. //CC: @weshaggard
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes lets try to avoid this if possible. I'd prefer we simply append "sources/generated" to the package-dir path we are already computing instead of having folks need this property in their tspconfig file.