Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename clientName param to moduleName #21893

Merged
merged 1 commit into from
Nov 6, 2023
Merged

Rename clientName param to moduleName #21893

merged 1 commit into from
Nov 6, 2023

Conversation

jhendrixMSFT
Copy link
Member

Per spec, the tracer name should be the name of the module. Removed some unnecessary code.

  • The purpose of this PR is explained in this or a referenced issue.
  • The PR does not update generated files.
  • Tests are included and/or updated for code changes.
  • Updates to module CHANGELOG.md are included.
  • MIT license headers are included in each file.

@jhendrixMSFT
Rename clientName param to moduleName
27c80ac 
Per spec, the tracer name should be the name of the module.
Removed some unnecessary code.
@jhendrixMSFT jhendrixMSFT requested a review from lmolkova November 6, 2023 18:28
@jhendrixMSFT jhendrixMSFT mentioned this pull request Nov 6, 2023
Merged
5 tasks
@jhendrixMSFT jhendrixMSFT merged commit 8c1a496 into Azure:main Nov 6, 2023
@jhendrixMSFT jhendrixMSFT deleted the azcore-module-param branch November 6, 2023 18:45
@jhendrixMSFT jhendrixMSFT mentioned this pull request Nov 6, 2023
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richardpark-msft richardpark-msft richardpark-msft approved these changes

@lmolkova lmolkova lmolkova approved these changes

@RickWinter RickWinter Awaiting requested review from RickWinter RickWinter is a code owner

@chlowell chlowell Awaiting requested review from chlowell chlowell is a code owner

Assignees
No one assigned
Labels
Azure.Core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jhendrixMSFT @lmolkova @richardpark-msft