Avoid warning on sporadic connection failures #39021
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeanbisutti
commented
Feb 29, 2024
| @@ -26,7 +24,7 @@ public static TelemetryItemExporter createTelemetryItemExporter(HttpPipeline htt | |||
| if (tempDir == null) { | |||
| telemetryPipelineListener = | |||
| new DiagnosticTelemetryPipelineListener( | |||
| "Sending telemetry to the ingestion service", false, " (telemetry will be lost)"); | |||
| "Sending telemetry to the ingestion service", false, true, " (telemetry will be lost)"); | |||
There was a problem hiding this comment.
No retry in this case, so exceptions should be logged
| @@ -41,6 +41,7 @@ class LocalFileSender implements Runnable { | |||
| new DiagnosticTelemetryPipelineListener( | |||
| "Sending telemetry to the ingestion service (retry from disk)", | |||
| true, | |||
| true, | |||
There was a problem hiding this comment.
Log exceptions on retry
jeanbisutti
commented
Feb 29, 2024
| @@ -101,7 +101,7 @@ public void onResponse(TelemetryPipelineRequest request, TelemetryPipelineRespon | |||
| public void onException(TelemetryPipelineRequest request, String reason, Throwable throwable) { | |||
| if (!NetworkFriendlyExceptions.logSpecialOneTimeFriendlyException( | |||
| throwable, request.getUrl().toString(), friendlyExceptionThrown, logger)) { | |||
| if (logRetryableFailures) { | |||
| if (logOnException) { | |||
There was a problem hiding this comment.
If logOnException is false, then OperationLogger won't record a failure.
Then, AggregatingLogger won't record a warning:
Then,
WARN c.a.m.o.e.i.p.TelemetryPipeline - Sending telemetry to the ingestion service: Channel response timed out after 60000 milliseconds. (...) (future warnings will be aggregated and logged once every 5 minutes)
java.util.concurrent.TimeoutException: Channel response timed out after 60000 milliseconds.
at com.azure.core.http.netty.implementation.ResponseTimeoutHandler.responseTimedOut(ResponseTimeoutHandler.java:58)
at com.azure.core.http.netty.implementation.ResponseTimeoutHandler.lambda$handlerAdded$0(ResponseTimeoutHandler.java:45)
at io.netty.util.concurrent.PromiseTask.runTask(PromiseTask.java:98)
at io.netty.util.concurrent.ScheduledFutureTask.run(ScheduledFutureTask.java:153)
at io.netty.util.concurrent.AbstractEventExecutor.runTask(AbstractEventExecutor.java:174)
at io.netty.util.concurrent.AbstractEventExecutor.safeExecute(AbstractEventExecutor.java:167)
at io.netty.util.concurrent.SingleThreadEventExecutor.runAllTasks(SingleThreadEventExecutor.java:470)
at io.netty.channel.epoll.EpollEventLoop.run(EpollEventLoop.java:403)
at io.netty.util.concurrent.SingleThreadEventExecutor$4.run(SingleThreadEventExecutor.java:997)
at io.netty.util.internal.ThreadExecutorMap$2.run(ThreadExecutorMap.java:74)
at io.netty.util.concurrent.FastThreadLocalRunnable.run(FastThreadLocalRunnable.java:30)
at java.lang.Thread.run(Thread.java:748)
won't be displayed:
And
WARN c.a.m.o.e.i.p.TelemetryPipeline - In the last 5 minutes, the following operation has failed 1 times (out of 30): Sending telemetry to the ingestion service:
* finishConnect(..) failed: Connection refused: (1 times)
won't be displayed:
jeanbisutti
commented
Feb 29, 2024
|
IIRC, microsoft/ApplicationInsights-Java#3564 should fix for Java agent? (and we could make similar change in standalone exporter) |
|
API change check API changes are not detected in this pull request. |
So, the Java agent has his own code for this. I see that your preference is also to disable the logs related to the Breeze response processing (when a retry is possible). I am fine with that and has updated this PR in this way. |
trask
reviewed
Mar 4, 2024
...n/java/com/azure/monitor/opentelemetry/exporter/implementation/utils/AzureMonitorHelper.java
Outdated
Show resolved
Hide resolved
…/com/azure/monitor/opentelemetry/exporter/implementation/utils/AzureMonitorHelper.java Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
trask
approved these changes
Mar 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes, the OTel exporter fails to send the telemetry data because of a time out:
It's not really an issue if it happens from time to time because the OTel exporter will save the telemetry data on the disk and will resend them later.