Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid warning on sporadic connection failures #39021

Merged
merged 7 commits into from
Mar 6, 2024
Merged

Avoid warning on sporadic connection failures #39021

Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
2ed0e59
Avoid warning on sporadic connection failures
jeanbisutti Feb 29, 2024
2f3fa96
Don't log exceptions when retry
jeanbisutti Feb 29, 2024
14dd0f9
Enable log on exception
jeanbisutti Feb 29, 2024
d67e1db
Do not log on response processing if possible retryable
jeanbisutti Mar 1, 2024
a8aed1c
Update DiagnosticTelemetryPipelineListener.java
jeanbisutti Mar 1, 2024
106f6f0
Update AzureMonitorHelper.java
jeanbisutti Mar 1, 2024
9f67c36
Update sdk/monitor/azure-monitor-opentelemetry-exporter/src/main/java…
jeanbisutti Mar 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions ...ava/com/azure/monitor/opentelemetry/exporter/implementation/utils/AzureMonitorHelper.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ public static TelemetryItemExporter createTelemetryItemExporter(HttpPipeline htt
if (tempDir == null) {
telemetryPipelineListener =
new DiagnosticTelemetryPipelineListener(
"Sending telemetry to the ingestion service", false, " (telemetry will be lost)");
"Sending telemetry to the ingestion service", true, " (telemetry will be lost)");
} else {
telemetryPipelineListener =
TelemetryPipelineListener.composite(
Expand All @@ -35,8 +35,8 @@ public static TelemetryItemExporter createTelemetryItemExporter(HttpPipeline htt
// will log if that retry from disk fails
new DiagnosticTelemetryPipelineListener(
"Sending telemetry to the ingestion service",
true,
" (telemetry will be stored to disk and retried)"),
false,
""),
new LocalStorageTelemetryPipelineListener(
50, // default to 50MB
TempDirs.getSubDir(tempDir, "telemetry"),
Expand Down
Loading