Added pipeline to validate spec location #28303
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raych1
requested review from
ckairen,
mikeharder,
weshaggard and
benbp
as code owners
weshaggard
approved these changes
Jan 19, 2024
weshaggard
added a commit
that referenced
this pull request
Jan 22, 2024
Reverts #28303 There is an incorrect assumption at https://github.com/Azure/azure-sdk-for-js/blob/main/eng/common/scripts/Verify-RestApiSpecLocation.ps1#L235 for the JS repo which doesn't have the package name in the path like other languages.
raych1
added a commit
that referenced
this pull request
Jan 25, 2024
This PR is to add back the spec location validation back to the release pipeline. Here is the original PR which was reverted by an issue of the JS package path. #28303 Here is the PR of the fix of common script that has been merged: Azure/azure-sdk-tools#7569 This is the [test run result](https://dev.azure.com/azure-sdk/internal/_build/results?buildId=3433518&view=logs&j=7bb69cc7-6f52-585e-8b13-5bae7c4a9fa4&t=7abbbe6b-d005-5c95-feb6-99ffe4e699e1) in JS repo. @weshaggard @jeremymeng , please review.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this PR
The purpose is to gate on the REST API specifications used to release SDK are from the main branch of Azure/azure-rest-api-spec.
Packages impacted by this PR
All the data plane GA packages to be released.
I scanned through this JS repo and identified 11 data plane services that have released GA packages but their configuration file either
tsp-location.yamlorswagger\README.mdreference the REST API specs from a non-main branch of Azure spec repo.Please refer to this spreadsheet to get the details of all the violated packages.
After this PR is merged, the next GA release for these packages will be blocked. They need to correct the spec path before releasing GA packages.
Describe the problem that is addressed by this PR
Added a pipeline from common template to release pipeline to validate the REST API specification location is from the main branch of Azure/azure-rest-api-spec.
This validation will be skipped if the package to be released is non-GA package.
Provide a list of related PRs
The common script and pipeline were merged by another PR.
Azure/azure-sdk-tools#7451
FYI - The same change has been added to other language repos' release pipelines.
Azure/azure-sdk-for-net#40783
Azure/azure-sdk-for-java#38332