Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correct the name of JS package folder #7569

Merged
merged 4 commits into from
Jan 25, 2024
Merged

Correct the name of JS package folder #7569

merged 4 commits into from
Jan 25, 2024

Conversation

raych1
Copy link
Member

@raych1 raych1 commented Jan 23, 2024 •
edited
Loading

There are two cases for the naming of JS package folder:

  • RLC package case, removing the "azure-rest-" from package name then plus "-rest" to the end of the name.
  • Non-RLC package case, removing the "azure-" from the package name.

The changes include:

  • correct the name of package folder for JS case.
  • correct the name prefix of JS ARM package.
  • add exception catch handler
  • style format fix

The pipeline test run of JS template package release with same script change looks good.

@raych1 raych1 requested a review from qiaozha January 23, 2024 10:55
@azure-sdk
Copy link
Collaborator

The following pipelines have been queued for testing:
java - template
java - template - tests
js - template
net - template
net - template - tests
python - template
python - template - tests
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

This was referenced Jan 23, 2024
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
@azure-sdk
Copy link
Collaborator

The following pipelines have been queued for testing:
java - template
java - template - tests
js - template
net - template
net - template - tests
python - template
python - template - tests
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

@azure-sdk
Copy link
Collaborator

The following pipelines have been queued for testing:
java - template
java - template - tests
js - template
net - template
net - template - tests
python - template
python - template - tests
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

weshaggard
weshaggard requested changes Jan 23, 2024
View reviewed changes
Copy link
Member

@weshaggard weshaggard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's switch to using the package info properties instead of duplicating logic.

@raych1
Copy link
Member Author

raych1 commented Jan 24, 2024

Let's switch to using the package info properties instead of duplicating logic.

@weshaggard , switched to rely on the package info. This is the test run result.

@azure-sdk
Copy link
Collaborator

The following pipelines have been queued for testing:
java - template
java - template - tests
js - template
net - template
net - template - tests
python - template
python - template - tests
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

azure-sdk added a commit to Azure/azure-sdk-for-js that referenced this pull request Jan 25, 2024
@azure-sdk @raych1
Sync eng/common directory with azure-sdk-tools for PR 7569 (#28341)
7b80a95 
Sync eng/common directory with azure-sdk-tools for PR
Azure/azure-sdk-tools#7569 See [eng/common
workflow](https://github.com/Azure/azure-sdk-tools/blob/main/eng/common/README.md#workflow)

---------

Co-authored-by: Ray Chen <raychen@microsoft.com>
@raych1 raych1 merged commit 06cb15a into main Jan 25, 2024
11 checks passed
@raych1 raych1 deleted the user/raych1/fix-js-package-folder-name branch January 25, 2024 10:16
@raych1 raych1 mentioned this pull request Jan 25, 2024
Merged
raych1 added a commit to Azure/azure-sdk-for-js that referenced this pull request Jan 25, 2024
@raych1
Added spec location validation pipeline (#28368)
76913f3 
This PR is to add back the spec location validation back to the release
pipeline.
Here is the original PR which was reverted by an issue of the JS package
path.
#28303

Here is the PR of the fix of common script that has been merged:
Azure/azure-sdk-tools#7569

This is the [test run
result](https://dev.azure.com/azure-sdk/internal/_build/results?buildId=3433518&view=logs&j=7bb69cc7-6f52-585e-8b13-5bae7c4a9fa4&t=7abbbe6b-d005-5c95-feb6-99ffe4e699e1)
in JS repo.

@weshaggard @jeremymeng , please review.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@weshaggard weshaggard weshaggard approved these changes

@konrad-jamrozik konrad-jamrozik Awaiting requested review from konrad-jamrozik

@benbp benbp Awaiting requested review from benbp

@qiaozha qiaozha Awaiting requested review from qiaozha

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@raych1 @azure-sdk @weshaggard