Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Centralize on one toml library #31761

Closed
wants to merge 3 commits into from
Closed

Centralize on one toml library #31761

wants to merge 3 commits into from

Conversation

scbedd
Copy link
Member

@scbedd scbedd commented Aug 22, 2023

tomli was still maintained by the owner up till py311. Let's just stick with that.

@scbedd
Copy link
Member Author

scbedd commented Aug 22, 2023 •
edited
Loading

I did some digging. Want to facepalm so hard. One of necessary functions is dump, which tomli doesn't support as it's read only.

I'm certain this is why the pytoml dep was added to begin with. Regardless I'll fix before merging.

@scbedd
Copy link
Member Author

scbedd commented Sep 15, 2023

This will be taken care of by #32066

@scbedd scbedd closed this Sep 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lmazuel lmazuel lmazuel approved these changes

@weshaggard weshaggard Awaiting requested review from weshaggard weshaggard is a code owner

@benbp benbp Awaiting requested review from benbp benbp is a code owner

Assignees

@scbedd scbedd

Labels
None yet
Projects
Azure SDK EngSys 🤖🧠
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@scbedd @lmazuel @mccoyp