Upgrade Sphinx #32066
Merged
Upgrade Sphinx #32066
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scbedd
commented
Sep 14, 2023
scbedd
commented
Sep 14, 2023
sdk/core/azure-core/tests/async_tests/test_rest_response_backcompat_async.py
Outdated
Show resolved
Hide resolved
scbedd
requested review from
weshaggard,
benbp,
lmazuel,
annatisch,
johanste,
xiangyan99,
tjprescott,
iscai-msft and
kashifkhan
as code owners
|
API change check API changes are not detected in this pull request. |
Closed
|
EDIT: fixed. |
scbedd
commented
Sep 15, 2023
iscai-msft
approved these changes
Sep 21, 2023
mccoyp
pushed a commit
to mccoyp/azure-sdk-for-python
that referenced
this pull request
Oct 7, 2023
* updates to test sever, removing a couple of the pins from test_tools and ci_tools.txt * remove bad readme_renderer requirement * simplifying requirements. fixing requirement file for invoking analyze * repair issues with pypy39 due to twine installation * exclude azure-core-tracing-opencensus from sphinx build * eliminate pytoml dependency * Update Sphinx to v6.x * safe import of tomli on <py311. import tomllib on >=py311. always pull in toml-w Co-authored-by: Laurent Mazuel <laurent.mazuel@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@lmazuel I can read between the lines when I'm being pinged on other issues tangential to sphinx.
cmarkgfm, for instance.TODO:
FixSpoke with @pvaneck this package isn't worth the effort of fixing.azure-core-tracing-opencensusnot building docs properlyUnfortunately this PR as-is doesn't account for sphinx updates, so the output looks a bit wonky.Ran it down. The issue is that the
azure.core.rstsphinx source includes subpackages:azure.core.pipelineazure.core.pollingazure.core.tracingazure.core.utilsBut these do not show up in the subpackages listing in the ToC. This is incorrect as far as I can tell.
But the additional four members
['AsyncPipelineClient', 'CaseInsensitiveEnumMeta', 'MatchConditions', 'PipelineClient']really are part ofazure.coreroot, so those showing up there is actually correct.Letting this run to see what else breaks in terms of our other requirements.
EDIT: looks like it's only when honoring a set of existing documents that we have a problem. See storage: