Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Sphinx to v6.x #32110

Closed
wants to merge 1 commit into from
Closed

Update Sphinx to v6.x #32110

wants to merge 1 commit into from

Conversation

lmazuel
Copy link
Member

@lmazuel lmazuel commented Sep 15, 2023

Move Sphinx to v6.x (matches the doc website version).

Few notes:

  • Supports only MD now as Readme input format (we don't have RST anymore anyway)
  • Don't convert those MD to RST, let Sphinx deal with it himself
  • Update Jinja in a few places to latest version
  • Remove deprecated sphinx plugin for MD, and use current recommendation myst-parser

cc @scbedd

@scbedd
Copy link
Member

scbedd commented Sep 15, 2023

#32066 This ended up being a messy upgrade to fix cmarkgfm. A ton more dependencies needed to be upgraded to get a clean run.

I can either merge that into this or merge this into that. Let me know! I have a mostly clean run aside from the sphinx updates that you've added here.

EDIT: the test timeout is due to this test for some reason on flask > 1 it just....hangs downloading.

@scbedd
Copy link
Member

scbedd commented Sep 18, 2023

I'm going to do an adjusted cherry pick of this PR into mine. To get all the environments running properly I had to update a bunch of requirements here and there. Given that so many updated, I think it'll be easier to merge your sphinx conf changes into mine.

EDIT: cherry-picked commit

@lmazuel lmazuel closed this Sep 29, 2023
@lmazuel lmazuel deleted the sphinx_update branch September 29, 2023 23:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants